Skip to content

Trace identity #6455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SuyogSoti merged 8 commits into from
Jul 25, 2019
Merged

Trace identity #6455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
54bc8c8
make sure its int. Need it to pass the test
SuyogSoti Jul 23, 2019
58ff6e7
added policy and decorator
SuyogSoti Jul 23, 2019
27d606e
dont decorate authn
SuyogSoti Jul 23, 2019
2e280c6
loggin policy behind retry policy
SuyogSoti Jul 24, 2019
5843d73
managed should not be decoratored
SuyogSoti Jul 24, 2019
4af99ad
dont need my workaround
SuyogSoti Jul 24, 2019
0810c1c
dont trace get_token
SuyogSoti Jul 24, 2019
0f08f8c
dont need this extra indent
SuyogSoti Jul 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sdk/identity/azure-identity/azure/identity/_authn_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
from azure.core.exceptions import ClientAuthenticationError
from azure.core.pipeline import Pipeline
from azure.core.pipeline.policies import ContentDecodePolicy, NetworkTraceLoggingPolicy, RetryPolicy
from azure.core.pipeline.policies.distributed_tracing import DistributedTracingPolicy
from azure.core.pipeline.transport import HttpTransport, RequestsTransport
from msal import TokenCache

Expand Down Expand Up @@ -119,7 +120,7 @@ class AuthnClient(AuthnClientBase):
def __init__(self, auth_url, config=None, policies=None, transport=None, **kwargs):
# type: (str, Optional[Configuration], Optional[Iterable[HTTPPolicy]], Optional[HttpTransport], Mapping[str, Any]) -> None
config = config or self.create_config(**kwargs)
policies = policies or [ContentDecodePolicy(), config.logging_policy, config.retry_policy]
policies = policies or [ContentDecodePolicy(), config.retry_policy, config.logging_policy, DistributedTracingPolicy()]
if not transport:
transport = RequestsTransport(**kwargs)
self._pipeline = Pipeline(transport=transport, policies=policies)
Expand Down
8 changes: 7 additions & 1 deletion sdk/identity/azure-identity/azure/identity/aio/_authn_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
from azure.core import Configuration
from azure.core.credentials import AccessToken
from azure.core.pipeline import AsyncPipeline
from azure.core.pipeline.policies.distributed_tracing import DistributedTracingPolicy
from azure.core.pipeline.policies import AsyncRetryPolicy, ContentDecodePolicy, HTTPPolicy, NetworkTraceLoggingPolicy
from azure.core.pipeline.transport import AsyncHttpTransport
from azure.core.pipeline.transport.requests_asyncio import AsyncioRequestsTransport
Expand All @@ -27,7 +28,12 @@ def __init__(
**kwargs: Mapping[str, Any]
) -> None:
config = config or self.create_config(**kwargs)
policies = policies or [ContentDecodePolicy(), config.logging_policy, config.retry_policy]
policies = policies or [
ContentDecodePolicy(),
config.retry_policy,
config.logging_policy,
DistributedTracingPolicy(),
]
if not transport:
transport = AsyncioRequestsTransport(**kwargs)
self._pipeline = AsyncPipeline(transport=transport, policies=policies)
Expand Down