Skip to content

Implement synchronous device code credential #6464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chlowell merged 8 commits into from
Aug 1, 2019
Merged

Implement synchronous device code credential #6464

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
57d5d41
device code credential
chlowell Jul 16, 2019
b0e32b0
offline tests
chlowell Jul 23, 2019
84d67dd
AAD timeout trumps user's
chlowell Jul 26, 2019
923c9a3
include code lifetime in callback
chlowell Jul 26, 2019
2ee0f3d
remove low-value test
chlowell Jul 26, 2019
4ad311c
reorganize
chlowell Jul 30, 2019
39ea2a7
fix docstring formatting
chlowell Jul 30, 2019
18a2a95
prevent leaking MSAL exceptions
chlowell Jul 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix docstring formatting
  • Loading branch information
@chlowell
chlowell committed Jul 31, 2019
commit 39ea2a76f3d0bdba39dcca7da5904ccf49176cdb
15 changes: 9 additions & 6 deletions sdk/identity/azure-identity/azure/identity/credentials.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,10 +271,12 @@ class DeviceCodeCredential(PublicClientCredential):

**Keyword arguments:**

*tenant (str)* - a tenant ID or a domain associated with a tenant. If not provided, the credential defaults to the
'organizations' tenant, which supports only Azure Active Directory work or school accounts.
*timeout (int)* - seconds to wait for the user to authenticate. Defaults to the validity period of the device code
as set by Azure Active Directory, which also prevails when ``timeout`` is longer.
- *tenant (str)* - tenant ID or a domain associated with a tenant. If not provided, the credential defaults to the
'organizations' tenant, which supports only Azure Active Directory work or school accounts.

- *timeout (int)* - seconds to wait for the user to authenticate. Defaults to the validity period of the device code
as set by Azure Active Directory, which also prevails when ``timeout`` is longer.

"""

def __init__(self, client_id, prompt_callback=None, **kwargs):
Expand Down Expand Up @@ -345,8 +347,9 @@ class UsernamePasswordCredential(PublicClientCredential):

**Keyword arguments:**

*tenant (str)* - a tenant ID or a domain associated with a tenant. If not provided, the credential defaults to the
'organizations' tenant.
- **tenant (str)** - a tenant ID or a domain associated with a tenant. If not provided, defaults to the
'organizations' tenant.

"""

def __init__(self, client_id, username, password, **kwargs):
Expand Down