Skip to content

[azure-core] Small fixes for aiohttp #6490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lmazuel merged 12 commits into from
Jul 26, 2019
Merged

[azure-core] Small fixes for aiohttp #6490

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
2b9b623
Aiohttp read timeout
annatisch Jul 25, 2019
1063947
Aiohttp response status code
annatisch Jul 25, 2019
bfc8559
Aiohttp content type header
annatisch Jul 25, 2019
d49db74
Review feedback
annatisch Jul 25, 2019
c85c2dc
Fixed typo
annatisch Jul 25, 2019
9fee28c
Fixed async transport sleep coroutine
annatisch Jul 25, 2019
e8c075a
Fix for stream generators
annatisch Jul 25, 2019
bef7396
Reverted attribute error handling
annatisch Jul 25, 2019
e37b6e0
Fixed trio sleep test
annatisch Jul 25, 2019
969821c
Fixed identity test mocks
annatisch Jul 26, 2019
f1c8a57
Fix identity mock to return content-type as string
lmazuel Jul 26, 2019
6d68103
Fix universal policy tests
lmazuel Jul 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Aiohttp read timeout
  • Loading branch information
@annatisch
annatisch committed Jul 25, 2019
commit 2b9b623d2c099373846f812dca3a2b98f8598fe9
5 changes: 3 additions & 2 deletions sdk/core/azure-core/azure/core/pipeline/transport/aiohttp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
import aiohttp

from azure.core.configuration import ConnectionConfiguration
from azure.core.exceptions import ServiceRequestError
from azure.core.exceptions import ServiceRequestError, ServiceResponseError
from azure.core.pipeline import Pipeline

from requests.exceptions import (
Expand Down Expand Up @@ -181,7 +181,8 @@ async def send(self, request: HttpRequest, **config: Any) -> Optional[AsyncHttpR
await response.load_body()
except aiohttp.client_exceptions.ClientConnectorError as err:
error = ServiceRequestError(err, error=err)

except asyncio.TimeoutError as err:
error = ServiceResponseError(err, error=err)
if error:
raise error
return response
Expand Down