Retry decorator and livetest update #6555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

yunhaoling wants to merge 15 commits into eventhubs_preview2 from eventhubs_dev

Contributor

yunhaoling commented Jul 30, 2019

Refactor the retry logic with decorator to improve reusability
Add livetest for create_event_batch

yunhaoling added 3 commits

July 30, 2019 13:16


          use decorator to implement retry logic and update some tests (#6544)

6394f19


          Update livetest (#6547)

56fdd1e


          Remove legacy code and update livetest (#6549)

10f0be6

* Update livetest

* Remove legacy code and update livetest

yunhaoling requested review from YijunXieMS and johanste

July 30, 2019 20:22

adxsdk6 commented Jul 30, 2019

Can one of the admins verify this patch?

yijxie and others added 8 commits

July 30, 2019 18:42


          make sync longrunning multi-threaded

fbb66bd


          small changes on async long running test

00ff723


          reset retry_count for iterator

0f5180c


          Don't return early when open a ReceiveClient or SendClient

6e0c238


          type annotation change

0efc95f


          Update kwargs and remove unused import

90fbafb


          raise asyncio.CancelledError out instead of supressing it.

dd1d7ae


          Update livetest and small fixed (#6594)

a31ee67

* Add missing close in livetest

* Update livetest to wait longer

* Close handler each time before retry

johanste reviewed

View reviewed changes

sdk/eventhub/azure-eventhubs/azure/eventhub/aio/producer_async.py Outdated Show resolved Hide resolved

johanste reviewed

View reviewed changes

sdk/eventhub/azure-eventhubs/azure/eventhub/_consumer_producer_mixin.py Outdated Show resolved Hide resolved

johanste reviewed

View reviewed changes

sdk/eventhub/azure-eventhubs/azure/eventhub/_consumer_producer_mixin.py Outdated Show resolved Hide resolved

johanste reviewed

View reviewed changes

sdk/eventhub/azure-eventhubs/azure/eventhub/_consumer_producer_mixin.py Outdated Show resolved Hide resolved

johanste reviewed

View reviewed changes

sdk/eventhub/azure-eventhubs/azure/eventhub/aio/client_async.py Outdated Show resolved Hide resolved

johanste reviewed

View reviewed changes

sdk/eventhub/azure-eventhubs/azure/eventhub/aio/consumer_async.py Outdated Show resolved Hide resolved

johanste reviewed

View reviewed changes

sdk/eventhub/azure-eventhubs/azure/eventhub/aio/producer_async.py Outdated Show resolved Hide resolved

johanste reviewed

View reviewed changes

sdk/eventhub/azure-eventhubs/azure/eventhub/common.py Outdated Show resolved Hide resolved

johanste reviewed

View reviewed changes

sdk/eventhub/azure-eventhubs/azure/eventhub/producer.py Outdated Show resolved Hide resolved


          Update code according to the review (#6623)

5ad0255

* Wait longer for reconnect op

* Raise authentication error when open timeout

* Optimize retry decorator

* Update code according to review

* Small fix

yunhaoling requested review from bryevdv and johanste

August 2, 2019 02:08

bryevdv reviewed

View reviewed changes

sdk/eventhub/azure-eventhubs/azure/eventhub/aio/consumer_async.py Outdated Show resolved Hide resolved

johanste reviewed

View reviewed changes

sdk/eventhub/azure-eventhubs/azure/eventhub/_consumer_producer_mixin.py Show resolved Hide resolved


           Update decorator implementation (#6642)

f8acc8b

* Update decorator implementation

yunhaoling requested a review from johanste

August 2, 2019 21:10

yunhaoling requested a review from bryevdv

August 2, 2019 21:10


          Update sample codes and docstring (#6643)

97dfce5

johanste reviewed

View reviewed changes

sdk/eventhub/azure-eventhubs/azure/eventhub/_consumer_producer_mixin.py Outdated Show resolved Hide resolved

johanste reviewed

View reviewed changes

sdk/eventhub/azure-eventhubs/azure/eventhub/aio/consumer_async.py Show resolved Hide resolved

johanste reviewed

View reviewed changes

sdk/eventhub/azure-eventhubs/tests/asynctests/test_negative_async.py Show resolved Hide resolved

johanste approved these changes

View reviewed changes

Member

johanste left a comment •

edited

Loading

The changes can go in. Let's do a broader review of the full code to see what/if there are any places where we can refactor code after b2 - assuming that the CI is green.


          Small fix (#6650)

0f670d8

* Draft for changelog

* Improve syntax for kwargs

Contributor Author

yunhaoling commented Aug 6, 2019

close this PR as all the changes have been merged to eventhubs_preview2 in another PR.

yunhaoling closed this

bryevdv reviewed

View reviewed changes

sdk/eventhub/azure-eventhubs/HISTORY.md Show resolved Hide resolved

bryevdv reviewed

View reviewed changes

sdk/eventhub/azure-eventhubs/azure/eventhub/_consumer_producer_mixin.py Show resolved Hide resolved

yunhaoling deleted the eventhubs_dev branch

August 7, 2019 00:16

yunhaoling mentioned this pull request

[EventHub] Retry refactor #7026

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lmazuel lmazuel left review comments

johanste johanste approved these changes

YijunXieMS Awaiting requested review from YijunXieMS

+2 more reviewers

brettcannon brettcannon left review comments

bryevdv bryevdv left review comments

Labels

None yet