Skip to content

azure-core black/pylint/mypy #6581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lmazuel merged 4 commits into from
Aug 1, 2019
Merged

azure-core black/pylint/mypy #6581

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d8bc07e
Pylint/black happyness
lmazuel Jul 31, 2019
30ce3f8
mypy
lmazuel Jul 31, 2019
5facaef
Fix exceptiont tests
lmazuel Jul 31, 2019
4fd65a7
bad-continuation ignroe by defulat
lmazuel Aug 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Pylint/black happyness
  • Loading branch information
@lmazuel
lmazuel committed Jul 31, 2019
commit d8bc07e13a860a4bf16fbc46915fe54cb6504067
13 changes: 8 additions & 5 deletions sdk/core/azure-core/azure/core/async_paging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,14 @@ async def __anext__(self) -> ReturnType:

class AsyncPageIterator(AsyncIterator[AsyncIterator[ReturnType]]):
def __init__(
self,
get_next: Callable[[Optional[str]], Awaitable[ResponseType]],
extract_data: Callable[
self, # pylint: disable=bad-continuation
get_next: Callable[ # pylint: disable=bad-continuation
[Optional[str]], Awaitable[ResponseType]
], # pylint: disable=bad-continuation
extract_data: Callable[ # pylint: disable=bad-continuation
[ResponseType], Awaitable[Tuple[str, AsyncIterator[ReturnType]]]
],
continuation_token: Optional[str] = None,
continuation_token: Optional[str] = None, # pylint: disable=bad-continuation
) -> None:
"""Return an async iterator of pages.

Expand Down Expand Up @@ -120,7 +122,8 @@ def __init__(self, *args, **kwargs) -> None:
)

def by_page(
self, continuation_token: Optional[str] = None
self, # pylint: disable=bad-continuation
continuation_token: Optional[str] = None, # pylint: disable=bad-continuation
) -> AsyncIterator[AsyncIterator[ReturnType]]:
"""Get an async iterator of pages of objects, instead of an async iterator of objects.

Expand Down
12 changes: 6 additions & 6 deletions sdk/core/azure-core/azure/core/paging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,14 @@
#
# --------------------------------------------------------------------------
import itertools
from typing import (
from typing import ( # pylint: disable=unused-import
Callable,
Optional,
TypeVar,
Iterator,
Iterable,
Tuple,
) # pylint: disable=unused-import
)
import logging


Expand All @@ -43,10 +43,10 @@

class PageIterator(Iterator[Iterator[ReturnType]]):
def __init__(
self,
get_next, # type: Callable[[Optional[str]], ResponseType]
extract_data, # type: Callable[[ResponseType], Tuple[str, Iterable[ReturnType]]]
continuation_token=None, # type: Optional[str]
self, # pylint: disable=bad-continuation
get_next, # type: Callable[[Optional[str]], ResponseType] # pylint: disable=bad-continuation
extract_data, # type: Callable[[ResponseType], Tuple[str, Iterable[ReturnType]]] # pylint: disable=bad-continuation
continuation_token=None, # type: Optional[str] # pylint: disable=bad-continuation
):
"""Return an iterator of pages.

Expand Down