[Storage Queue] Record async tests

eng/pipelines/templates/steps/publish-coverage.yml

@@ -13,6 +13,7 @@ steps:
   - task: PublishCodeCoverageResults@1
     displayName: 'Publish Code Coverage to DevOps'
     continueOnError: true
+    condition: ne(variables['Build.Reason'], 'PullRequest')
     inputs:
       codeCoverageTool: Cobertura
       summaryFileLocation: '$(Build.SourcesDirectory)/coverage.xml'

pylintrc

@@ -7,7 +7,8 @@ reports=no
 # locally-disabled: Warning locally suppressed using disable-msg
 # cyclic-import: because of https://github.com/PyCQA/pylint/issues/850
 # too-many-arguments: Due to the nature of the CLI many commands have large arguments set which reflect in large arguments set in corresponding methods.
-disable=useless-object-inheritance,missing-docstring,locally-disabled,fixme,cyclic-import,too-many-arguments,invalid-name,duplicate-code,too-few-public-methods
+# Let's black deal with bad-continuation
+disable=useless-object-inheritance,missing-docstring,locally-disabled,fixme,cyclic-import,too-many-arguments,invalid-name,duplicate-code,too-few-public-methods,bad-continuation
 
 [FORMAT]
 max-line-length=120

scripts/devops_tasks/common_tasks.py

@@ -15,6 +15,7 @@
 import sys
 
 DEFAULT_BUILD_PACKAGES = ['azure-keyvault', 'azure-servicebus']
+OMITTED_CI_PACKAGES = ['azure-mgmt-documentdb', 'azure-servicemanagement-legacy']
 
 # this function is where a glob string gets translated to a list of packages
 # It is called by both BUILD (package) and TEST. In the future, this function will be the central location
@@ -31,7 +32,21 @@ def process_glob_string(glob_string, target_root_dir):
         collected_top_level_directories.extend([os.path.dirname(p) for p in globbed])
 
     # dedup, in case we have double coverage from the glob strings. Example: "azure-mgmt-keyvault,azure-mgmt-*"
-    return list(set(collected_top_level_directories))
+    collected_directories = list(set(collected_top_level_directories))
+
+    # if we have individually queued this specific package, it's obvious that we want to build it specifically
+    # in this case, do not honor the omission list
+    if len(collected_directories) == 1:
+        return collected_directories
+    # however, if there are multiple packages being built, we should honor the omission list and NOT build the omitted
+    # packages
+    else:
+        return remove_omitted_packages(collected_directories)
+
+def remove_omitted_packages(collected_directories):
+    return [package_dir for package_dir in collected_directories if
+            os.path.basename(package_dir) not in OMITTED_CI_PACKAGES]
+
 
 def run_check_call(command_array, working_directory, acceptable_return_codes = [], run_as_shell = False):
     try:

scripts/devops_tasks/setup_execute_tests.py

@@ -95,8 +95,6 @@ def run_tests(targeted_packages, python_version, test_res):
     else:
         target_dir = root_dir
 
-    print(args.glob_string);
-
     targeted_packages = process_glob_string(args.glob_string, target_dir)
     test_results_arg = []
     if args.test_results:

sdk/alertsmanagement/azure-mgmt-alertsmanagement/HISTORY.rst

@@ -3,6 +3,13 @@
 Release History
 ===============
 
+0.2.0rc2 (2019-07-31)
++++++++++++++++++++++
+
+**Bugfix**
+
+- Fixed autogenerated code problems
+
 0.2.0rc1 (2019-07-29)
 +++++++++++++++++++++
 

sdk/alertsmanagement/azure-mgmt-alertsmanagement/azure/mgmt/alertsmanagement/_alerts_management_client.py

@@ -41,19 +41,15 @@ class AlertsManagementClient(SDKClient):
     :param credentials: Credentials needed for the client to connect to Azure.
     :type credentials: :mod:`A msrestazure Credentials
      object<msrestazure.azure_active_directory>`
-    :param subscription_id: Subscription credentials which uniquely identify
-     Microsoft Azure subscription. The subscription ID forms part of the URI
-     for every service call.
+    :param subscription_id: The ID of the target subscription.
     :type subscription_id: str
-    :param subscription_id1: The Azure subscription id.
-    :type subscription_id1: str
     :param str base_url: Service URL
     """
 
     def __init__(
-            self, credentials, subscription_id, subscription_id1, base_url=None):
+            self, credentials, subscription_id, base_url=None):
 
-        self.config = AlertsManagementClientConfiguration(credentials, subscription_id, subscription_id1, base_url)
+        self.config = AlertsManagementClientConfiguration(credentials, subscription_id, base_url)
         super(AlertsManagementClient, self).__init__(self.config.credentials, self.config)
 
         client_models = {k: v for k, v in models.__dict__.items() if isinstance(v, type)}

sdk/alertsmanagement/azure-mgmt-alertsmanagement/azure/mgmt/alertsmanagement/_configuration.py

@@ -21,24 +21,18 @@ class AlertsManagementClientConfiguration(AzureConfiguration):
     :param credentials: Credentials needed for the client to connect to Azure.
     :type credentials: :mod:`A msrestazure Credentials
      object<msrestazure.azure_active_directory>`
-    :param subscription_id: Subscription credentials which uniquely identify
-     Microsoft Azure subscription. The subscription ID forms part of the URI
-     for every service call.
+    :param subscription_id: The ID of the target subscription.
     :type subscription_id: str
-    :param subscription_id1: The Azure subscription id.
-    :type subscription_id1: str
     :param str base_url: Service URL
     """
 
     def __init__(
-            self, credentials, subscription_id, subscription_id1, base_url=None):
+            self, credentials, subscription_id, base_url=None):
 
         if credentials is None:
             raise ValueError("Parameter 'credentials' must not be None.")
         if subscription_id is None:
             raise ValueError("Parameter 'subscription_id' must not be None.")
-        if subscription_id1 is None:
-            raise ValueError("Parameter 'subscription_id1' must not be None.")
         if not base_url:
             base_url = 'https://management.azure.com'
 
@@ -52,4 +46,3 @@ def __init__(
 
         self.credentials = credentials
         self.subscription_id = subscription_id
-        self.subscription_id1 = subscription_id1

sdk/alertsmanagement/azure-mgmt-alertsmanagement/azure/mgmt/alertsmanagement/operations/_action_rules_operations.py

@@ -93,7 +93,7 @@ def prepare_request(next_link=None):
                 # Construct URL
                 url = self.list_by_subscription.metadata['url']
                 path_format_arguments = {
-                    'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str')
+                    'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str', min_length=1)
                 }
                 url = self._client.format_url(url, **path_format_arguments)
 
@@ -217,7 +217,7 @@ def prepare_request(next_link=None):
                 # Construct URL
                 url = self.list_by_resource_group.metadata['url']
                 path_format_arguments = {
-                    'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str'),
+                    'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str', min_length=1),
                     'resourceGroupName': self._serialize.url("resource_group_name", resource_group_name, 'str')
                 }
                 url = self._client.format_url(url, **path_format_arguments)
@@ -309,7 +309,7 @@ def get_by_name(
         # Construct URL
         url = self.get_by_name.metadata['url']
         path_format_arguments = {
-            'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str'),
+            'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str', min_length=1),
             'resourceGroupName': self._serialize.url("resource_group_name", resource_group_name, 'str'),
             'actionRuleName': self._serialize.url("action_rule_name", action_rule_name, 'str')
         }
@@ -380,7 +380,7 @@ def create_update(
         # Construct URL
         url = self.create_update.metadata['url']
         path_format_arguments = {
-            'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str'),
+            'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str', min_length=1),
             'resourceGroupName': self._serialize.url("resource_group_name", resource_group_name, 'str'),
             'actionRuleName': self._serialize.url("action_rule_name", action_rule_name, 'str')
         }
@@ -451,7 +451,7 @@ def delete(
         # Construct URL
         url = self.delete.metadata['url']
         path_format_arguments = {
-            'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str'),
+            'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str', min_length=1),
             'resourceGroupName': self._serialize.url("resource_group_name", resource_group_name, 'str'),
             'actionRuleName': self._serialize.url("action_rule_name", action_rule_name, 'str')
         }
@@ -527,7 +527,7 @@ def update(
         # Construct URL
         url = self.update.metadata['url']
         path_format_arguments = {
-            'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str'),
+            'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str', min_length=1),
             'resourceGroupName': self._serialize.url("resource_group_name", resource_group_name, 'str'),
             'actionRuleName': self._serialize.url("action_rule_name", action_rule_name, 'str')
         }

sdk/alertsmanagement/azure-mgmt-alertsmanagement/azure/mgmt/alertsmanagement/operations/_alerts_operations.py

@@ -191,7 +191,7 @@ def prepare_request(next_link=None):
                 # Construct URL
                 url = self.get_all.metadata['url']
                 path_format_arguments = {
-                    'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str')
+                    'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str', min_length=1)
                 }
                 url = self._client.format_url(url, **path_format_arguments)
 
@@ -292,7 +292,7 @@ def get_by_id(
         # Construct URL
         url = self.get_by_id.metadata['url']
         path_format_arguments = {
-            'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str'),
+            'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str', min_length=1),
             'alertId': self._serialize.url("alert_id", alert_id, 'str')
         }
         url = self._client.format_url(url, **path_format_arguments)
@@ -352,7 +352,7 @@ def change_state(
         # Construct URL
         url = self.change_state.metadata['url']
         path_format_arguments = {
-            'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str'),
+            'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str', min_length=1),
             'alertId': self._serialize.url("alert_id", alert_id, 'str')
         }
         url = self._client.format_url(url, **path_format_arguments)
@@ -412,7 +412,7 @@ def get_history(
         # Construct URL
         url = self.get_history.metadata['url']
         path_format_arguments = {
-            'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str'),
+            'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str', min_length=1),
             'alertId': self._serialize.url("alert_id", alert_id, 'str')
         }
         url = self._client.format_url(url, **path_format_arguments)
@@ -522,7 +522,7 @@ def get_summary(
         # Construct URL
         url = self.get_summary.metadata['url']
         path_format_arguments = {
-            'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str')
+            'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str', min_length=1)
         }
         url = self._client.format_url(url, **path_format_arguments)
 

sdk/alertsmanagement/azure-mgmt-alertsmanagement/azure/mgmt/alertsmanagement/operations/_smart_detector_alert_rules_operations.py

@@ -62,7 +62,7 @@ def prepare_request(next_link=None):
                 # Construct URL
                 url = self.list.metadata['url']
                 path_format_arguments = {
-                    'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str')
+                    'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str', min_length=1)
                 }
                 url = self._client.format_url(url, **path_format_arguments)
 
@@ -135,7 +135,7 @@ def prepare_request(next_link=None):
                 # Construct URL
                 url = self.list_by_resource_group.metadata['url']
                 path_format_arguments = {
-                    'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str'),
+                    'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str', min_length=1),
                     'resourceGroupName': self._serialize.url("resource_group_name", resource_group_name, 'str')
                 }
                 url = self._client.format_url(url, **path_format_arguments)
@@ -208,7 +208,7 @@ def get(
         # Construct URL
         url = self.get.metadata['url']
         path_format_arguments = {
-            'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str'),
+            'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str', min_length=1),
             'resourceGroupName': self._serialize.url("resource_group_name", resource_group_name, 'str'),
             'alertRuleName': self._serialize.url("alert_rule_name", alert_rule_name, 'str')
         }
@@ -272,7 +272,7 @@ def create_or_update(
         # Construct URL
         url = self.create_or_update.metadata['url']
         path_format_arguments = {
-            'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str'),
+            'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str', min_length=1),
             'resourceGroupName': self._serialize.url("resource_group_name", resource_group_name, 'str'),
             'alertRuleName': self._serialize.url("alert_rule_name", alert_rule_name, 'str')
         }
@@ -341,7 +341,7 @@ def patch(
         # Construct URL
         url = self.patch.metadata['url']
         path_format_arguments = {
-            'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str'),
+            'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str', min_length=1),
             'resourceGroupName': self._serialize.url("resource_group_name", resource_group_name, 'str'),
             'alertRuleName': self._serialize.url("alert_rule_name", alert_rule_name, 'str')
         }
@@ -404,7 +404,7 @@ def delete(
         # Construct URL
         url = self.delete.metadata['url']
         path_format_arguments = {
-            'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str'),
+            'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str', min_length=1),
             'resourceGroupName': self._serialize.url("resource_group_name", resource_group_name, 'str'),
             'alertRuleName': self._serialize.url("alert_rule_name", alert_rule_name, 'str')
         }

sdk/alertsmanagement/azure-mgmt-alertsmanagement/azure/mgmt/alertsmanagement/operations/_smart_groups_operations.py

@@ -109,7 +109,7 @@ def prepare_request(next_link=None):
                 # Construct URL
                 url = self.get_all.metadata['url']
                 path_format_arguments = {
-                    'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str')
+                    'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str', min_length=1)
                 }
                 url = self._client.format_url(url, **path_format_arguments)
 
@@ -198,7 +198,7 @@ def get_by_id(
         # Construct URL
         url = self.get_by_id.metadata['url']
         path_format_arguments = {
-            'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str'),
+            'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str', min_length=1),
             'smartGroupId': self._serialize.url("smart_group_id", smart_group_id, 'str')
         }
         url = self._client.format_url(url, **path_format_arguments)
@@ -263,7 +263,7 @@ def change_state(
         # Construct URL
         url = self.change_state.metadata['url']
         path_format_arguments = {
-            'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str'),
+            'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str', min_length=1),
             'smartGroupId': self._serialize.url("smart_group_id", smart_group_id, 'str')
         }
         url = self._client.format_url(url, **path_format_arguments)
@@ -327,7 +327,7 @@ def get_history(
         # Construct URL
         url = self.get_history.metadata['url']
         path_format_arguments = {
-            'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str'),
+            'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str', min_length=1),
             'smartGroupId': self._serialize.url("smart_group_id", smart_group_id, 'str')
         }
         url = self._client.format_url(url, **path_format_arguments)

sdk/alertsmanagement/azure-mgmt-alertsmanagement/azure/mgmt/alertsmanagement/version.py

@@ -9,5 +9,5 @@
 # regenerated.
 # --------------------------------------------------------------------------
 
-VERSION = "0.2.0rc1"
+VERSION = "0.2.0rc2"
 

sdk/core/azure-core/HISTORY.md

@@ -3,6 +3,27 @@
 
 -------------------
 
+2019-08-XX Version 1.0.0b2
+
+## Breaking changes
+
+- Transport classes don't take `config` parameter anymore (use kwargs instead)  #6372
+- `azure.core.paging` has been completely refactored  #6420
+- HttpResponse.content_type attribute is now a string (was a list)  #6490
+- For `StreamDownloadGenerator` subclasses, `response` is now an `HttpResponse`, and not a transport response like `aiohttp.ClientResponse` or `requests.Response`. The transport response is available in `internal_response` attribute  #6490
+
+## Bug fixes
+
+- aiohttp is not required to import async pipelines classes #6496
+- `AsyncioRequestsTransport.sleep` is now a coroutine as expected #6490
+- `RequestsTransport` is not tight to `ProxyPolicy` implementation details anymore #6372
+- `AiohttpTransport` does not raise on unexpected kwargs  #6355
+
+## Features
+
+- New paging base classes that support `continuation_token` and `by_page()`  #6420
+- Proxy support for `AiohttpTransport`  #6372
+
 2019-06-26 Version 1.0.0b1
 
 - Preview 1 release