Skip to content

Policies as kwargs for KeyVault #6616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chlowell merged 4 commits into from
Aug 3, 2019
Merged

Policies as kwargs for KeyVault #6616

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f7f91b6
Policies as kwargs
chlowell Aug 2, 2019
3f2e2cd
Move user agent constant out of _shared
chlowell Aug 2, 2019
0dd5e36
update shared code in azure-keyvault-secrets
chlowell Aug 2, 2019
1d95bc6
TODO
chlowell Aug 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Policies as kwargs
  • Loading branch information
@chlowell
chlowell committed Aug 2, 2019
commit f7f91b6e863fb5e609db4f03885f10960c922d94
16 changes: 16 additions & 0 deletions sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/_shared/async_client_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,22 @@ def _create_config(
# https://github.com/Azure/azure-sdk-for-python/issues/6637
config.user_agent_policy = UserAgentPolicy(base_user_agent=USER_AGENT, **kwargs)

# Override config policies if found in kwargs
if "user_agent_policy" in kwargs:
config.user_agent_policy = kwargs["user_agent_policy"]
if "headers_policy" in kwargs:
config.headers_policy = kwargs["headers_policy"]
if "proxy_policy" in kwargs:
config.proxy_policy = kwargs["proxy_policy"]
if "logging_policy" in kwargs:
config.logging_policy = kwargs["logging_policy"]
if "retry_policy" in kwargs:
config.retry_policy = kwargs["retry_policy"]
if "custom_hook_policy" in kwargs:
config.custom_hook_policy = kwargs["custom_hook_policy"]
if "redirect_policy" in kwargs:
config.redirect_policy = kwargs["redirect_policy"]

return config

def __init__(
Expand Down
16 changes: 16 additions & 0 deletions sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/_shared/client_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,22 @@ def _create_config(credential, api_version=None, **kwargs):
# https://github.com/Azure/azure-sdk-for-python/issues/6637
config.user_agent_policy = UserAgentPolicy(base_user_agent=USER_AGENT, **kwargs)

# Override config policies if found in kwargs
if "user_agent_policy" in kwargs:
config.user_agent_policy = kwargs["user_agent_policy"]
if "headers_policy" in kwargs:
config.headers_policy = kwargs["headers_policy"]
if "proxy_policy" in kwargs:
config.proxy_policy = kwargs["proxy_policy"]
if "logging_policy" in kwargs:
config.logging_policy = kwargs["logging_policy"]
if "retry_policy" in kwargs:
config.retry_policy = kwargs["retry_policy"]
if "custom_hook_policy" in kwargs:
config.custom_hook_policy = kwargs["custom_hook_policy"]
if "redirect_policy" in kwargs:
config.redirect_policy = kwargs["redirect_policy"]

return config

def __init__(self, vault_url, credential, transport=None, api_version=None, **kwargs):
Expand Down