Skip to content

Some final tweaks #6687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rakshith91 merged 5 commits into from
Aug 6, 2019
Merged

Some final tweaks #6687

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e929b69
Some final tweaks
rakshith91 Aug 6, 2019
614b478
oops
rakshith91 Aug 6, 2019
6a417a4
comments
rakshith91 Aug 6, 2019
d10697d
little better
rakshith91 Aug 6, 2019
15b637e
Pylint
rakshith91 Aug 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sdk/storage/azure-storage-blob/tests/test_large_block_blob.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@
LARGE_BLOCK_SIZE = 6 * 1024 * 1024

# ------------------------------------------------------------------------------

if platform.python_implementation() == 'PyPy':
Copy link
Member

@annatisch annatisch Aug 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to import platform

Copy link
Contributor Author

@rakshith91 rakshith91 Aug 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did that :D

pytest.skip("Skip tests for Pypy", allow_module_level=True)

class StorageLargeBlockBlobTest(StorageTestCase):
def setUp(self):
Expand Down
2 changes: 2 additions & 0 deletions sdk/storage/azure-storage-queue/tests/test_queue.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -813,6 +813,7 @@ def test_unicode_create_queue_unicode_name(self):

@record
def test_unicode_get_messages_unicode_data(self):
pytest.skip("Uncomment after msrest fix")
Copy link
Member

@annatisch annatisch Aug 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible that we could make this skip conditional on Python 2.7?

Copy link
Contributor

@kristapratico kristapratico Aug 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could use pytest "skipif" - https://pytest.readthedocs.io/en/2.8.7/skipping.html

Copy link
Contributor Author

@rakshith91 rakshith91 Aug 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

# Action
queue_client = self._create_queue()
queue_client.enqueue_message(u'message1㚈')
Expand All @@ -830,6 +831,7 @@ def test_unicode_get_messages_unicode_data(self):

@record
def test_unicode_update_message_unicode_data(self):
pytest.skip("Uncomment after msrest fix")
# Action
queue_client = self._create_queue()
queue_client.enqueue_message(u'message1')
Expand Down
2 changes: 1 addition & 1 deletion sdk/storage/azure-storage-queue/tests/test_queue_samples_message.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def test_set_access_policy(self):
queue_client.create_queue()
except ResourceExistsError:
pass
queue_client.enqueue_message('hello world')
queue_client.enqueue_message(u"hello world")

try:
# [START set_access_policy]
Expand Down