Skip to content

[storage] Better async import error message #6700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
annatisch merged 5 commits into from
Aug 6, 2019
Merged

[storage] Better async import error message #6700

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0647f11
Fix for queue models
annatisch Aug 6, 2019
2ab6c2e
Docs cleanups
annatisch Aug 6, 2019
bdcb007
Merge remote-tracking branch 'upstream/storage-preview2' into storage…
annatisch Aug 6, 2019
35ac8c9
Merge remote-tracking branch 'upstream/storage-preview2' into storage…
annatisch Aug 6, 2019
ffd0dce
Better async import error
annatisch Aug 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Better async import error
  • Loading branch information
@annatisch
annatisch committed Aug 6, 2019
commit ffd0dce36283e9c193f929d5fc8f98254ef980b4
5 changes: 4 additions & 1 deletion sdk/storage/azure-storage-blob/azure/storage/blob/_shared/base_client_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,10 @@ def _create_pipeline(self, credential, **kwargs):
if 'connection_timeout' not in kwargs:
kwargs['connection_timeout'] = DEFAULT_SOCKET_TIMEOUT[0] # type: ignore
if not config.transport:
from azure.core.pipeline.transport import AioHttpTransport
try:
from azure.core.pipeline.transport import AioHttpTransport
except ImportError:
raise ImportError("Unable to create async transport. Please check aiohttp is installed.")
config.transport = AioHttpTransport(**kwargs)
policies = [
QueueMessagePolicy(),
Expand Down
5 changes: 4 additions & 1 deletion sdk/storage/azure-storage-file/azure/storage/file/_shared/base_client_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,10 @@ def _create_pipeline(self, credential, **kwargs):
if 'connection_timeout' not in kwargs:
kwargs['connection_timeout'] = DEFAULT_SOCKET_TIMEOUT[0] # type: ignore
if not config.transport:
from azure.core.pipeline.transport import AioHttpTransport
try:
from azure.core.pipeline.transport import AioHttpTransport
except ImportError:
raise ImportError("Unable to create async transport. Please check aiohttp is installed.")
config.transport = AioHttpTransport(**kwargs)
policies = [
QueueMessagePolicy(),
Expand Down
5 changes: 4 additions & 1 deletion sdk/storage/azure-storage-queue/azure/storage/queue/_shared/base_client_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,10 @@ def _create_pipeline(self, credential, **kwargs):
if 'connection_timeout' not in kwargs:
kwargs['connection_timeout'] = DEFAULT_SOCKET_TIMEOUT[0] # type: ignore
if not config.transport:
from azure.core.pipeline.transport import AioHttpTransport
try:
from azure.core.pipeline.transport import AioHttpTransport
except ImportError:
raise ImportError("Unable to create async transport. Please check aiohttp is installed.")
config.transport = AioHttpTransport(**kwargs)
policies = [
QueueMessagePolicy(),
Expand Down