Skip to content
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[Core] Config not required for pipeline client
  • Loading branch information
annatisch authored Aug 28, 2019
commit bb56cd1ace01253e1f991c7ca54761715283cf39
8 changes: 4 additions & 4 deletions sdk/core/azure-core/azure/core/pipeline_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ class PipelineClient(PipelineClientBase):
Builds a Pipeline client.

:param str base_url: URL for the request.
:param config: Service configuration. This is a required parameter.
:param config: Service configuration. This is a required unless pipeline or policies are given separately.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing "parameter"?

:type config: ~azure.core.Configuration
:param kwargs: keyword arguments
:return: A pipeline object.
Expand All @@ -80,10 +80,8 @@ class PipelineClient(PipelineClientBase):
:caption: Builds the pipeline client.
"""

def __init__(self, base_url, config, **kwargs):
def __init__(self, base_url, config=None, **kwargs):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we put config into kwargs?

super(PipelineClient, self).__init__(base_url)
if config is None:
raise ValueError("Config is a required parameter")
self._config = config
self._base_url = base_url
if kwargs.get("pipeline"):
Expand All @@ -106,6 +104,8 @@ def _build_pipeline(self, config, **kwargs): # pylint: disable=no-self-use
policies = kwargs.get('policies')

if policies is None: # [] is a valid policy list
if config is None:
raise ValueError("No config or policies supplied.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not if config is None, give a default one?

policies = [
config.headers_policy,
config.user_agent_policy,
Expand Down