-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[Core] Config not required for pipeline client #6972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
[Core] Config not required for pipeline client
- Loading branch information
commit bb56cd1ace01253e1f991c7ca54761715283cf39
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -59,7 +59,7 @@ class PipelineClient(PipelineClientBase): | |
| Builds a Pipeline client. | ||
|
|
||
| :param str base_url: URL for the request. | ||
| :param config: Service configuration. This is a required parameter. | ||
| :param config: Service configuration. This is a required unless pipeline or policies are given separately. | ||
| :type config: ~azure.core.Configuration | ||
| :param kwargs: keyword arguments | ||
| :return: A pipeline object. | ||
|
|
@@ -80,10 +80,8 @@ class PipelineClient(PipelineClientBase): | |
| :caption: Builds the pipeline client. | ||
| """ | ||
|
|
||
| def __init__(self, base_url, config, **kwargs): | ||
| def __init__(self, base_url, config=None, **kwargs): | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we put config into kwargs? |
||
| super(PipelineClient, self).__init__(base_url) | ||
| if config is None: | ||
| raise ValueError("Config is a required parameter") | ||
| self._config = config | ||
| self._base_url = base_url | ||
| if kwargs.get("pipeline"): | ||
|
|
@@ -106,6 +104,8 @@ def _build_pipeline(self, config, **kwargs): # pylint: disable=no-self-use | |
| policies = kwargs.get('policies') | ||
|
|
||
| if policies is None: # [] is a valid policy list | ||
| if config is None: | ||
| raise ValueError("No config or policies supplied.") | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why not if config is None, give a default one? |
||
| policies = [ | ||
| config.headers_policy, | ||
| config.user_agent_policy, | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing "parameter"?