incorporated Charles' and Johan's comments

sdk/keyvault/azure-keyvault-certificates/README.md

@@ -212,7 +212,7 @@ create_certificate_result = await create_certificate_poller
 print(create_certificate_result)
 ```
 
-### Asynchronously list keys
+### Asynchronously list certificates
 This example lists all the certificates in the client's vault:
 ```python
 certificates = certificate_client.list_certificates()

sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/_polling.py

@@ -1,12 +1,10 @@
-# -------------------------------------------------------------------------
-# Copyright (c) Microsoft Corporation. All rights reserved.
-# Licensed under the MIT License. See License.txt in the project root for
-# license information.
-# --------------------------------------------------------------------------
+# ------------------------------------
+# Copyright (c) Microsoft Corporation.
+# Licensed under the MIT License.
+# ------------------------------------
 import logging
 import time
 
-from azure.core.exceptions import HttpResponseError
 from azure.core.polling import PollingMethod
 from azure.keyvault.certificates._shared import parse_vault_id
 
@@ -38,9 +36,6 @@ def run(self):
         try:
             while not self.finished():
                 self._update_status()
-                if self._status != 'completed' and self._status != 'inprogress' and self._status != 'cancelled':
-                    raise HttpResponseError(
-                        'Unknown status \'{}\' for pending certificate {}'.format(self._status, self._certificate_id))
                 time.sleep(self.polling_interval)
         except Exception as e:
             logger.warning(str(e))
@@ -50,7 +45,7 @@ def finished(self):
         # type: () -> bool
         if self.unknown_issuer:
             return True
-        return self._status != 'inprogress'
+        return self._status in ('completed', 'cancelled', 'failed')
 
     def resource(self):
         # type: () -> str

sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/aio/_polling_async.py

@@ -1,14 +1,12 @@
-# -------------------------------------------------------------------------
-# Copyright (c) Microsoft Corporation. All rights reserved.
-# Licensed under the MIT License. See License.txt in the project root for
-# license information.
-# --------------------------------------------------------------------------
+# ------------------------------------
+# Copyright (c) Microsoft Corporation.
+# Licensed under the MIT License.
+# ------------------------------------
 
 import asyncio
 import logging
 from typing import Any, Callable
 
-from azure.core import HttpResponseError
 from azure.core.polling import AsyncPollingMethod
 from azure.keyvault.certificates._shared import parse_vault_id
 
@@ -24,41 +22,32 @@ def __init__(self, interval=5, unknown_issuer=False):
         self.polling_interval = interval
         self.unknown_issuer = unknown_issuer
 
-    async def _update_status(self):
-        # type: () -> None
+    async def _update_status(self) -> None:
         pending_certificate = await self._command()
         self._status = pending_certificate.status.lower()
         if not self._certificate_id:
             self._certificate_id = parse_vault_id(pending_certificate.id)
 
-    def initialize(self, client, initial_response, _):
-        # type: (Any, Any, Callable) -> None
+    def initialize(self, client: Any, initial_response: Any, _: Callable) -> None:
         self._command = client
         self._status = initial_response
 
-    async def run(self):
-        # type: () -> None
+    async def run(self) -> None:
         try:
             while not self.finished():
                 await self._update_status()
-                if self._status != 'completed' and self._status != 'inprogress' and self._status != 'cancelled':
-                    raise HttpResponseError(
-                        'Unknown status \'{}\' for pending certificate {}'.format(self._status, self._certificate_id))
                 await asyncio.sleep(self.polling_interval)
         except Exception as e:
             logger.warning(str(e))
             raise
 
-    def finished(self):
-        # type: () -> bool
+    def finished(self) -> bool:
         if self.unknown_issuer:
             return True
-        return self._status == 'completed' or self._status == 'cancelled'
+        return self._status in ('completed', 'cancelled', 'failed')
 
-    def resource(self):
-        # type: () -> Any
+    def resource(self) -> Any:
         return self._status
 
-    def status(self):
-        # type: () -> str
+    def status(self) -> str:
         return self._status

sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/aio/client.py

@@ -68,7 +68,7 @@ async def create_certificate(
         :param tags: Application specific metadata in the form of key-value pairs.
         :type tags: dict(str, str)
         :returns: The created CertificateOperation
-        :rtype: ~azure.keyvault.certificates.models.CertificateOperation
+        :rtype: coroutine
         :raises: ~azure.core.exceptions.HttpResponseError
 
         Example:
@@ -109,7 +109,7 @@ async def create_certificate(
                                        subject_name="CN=DefaultPolicy",
                                        validity_in_months=12)
 
-        await self._client.create_certificate(
+        create_certificate_operation = await self._client.create_certificate(
             vault_base_url=self.vault_url,
             certificate_name=name,
             certificate_policy=policy._to_certificate_policy_bundle(),
@@ -129,7 +129,7 @@ async def create_certificate(
             unknown_issuer=(policy.issuer_name.lower() == 'unknown'))
         return async_poller(
             command,
-            "inprogress",
+            create_certificate_operation.status.lower(),
             None,
             create_certificate_polling
         )
@@ -140,13 +140,12 @@ async def get_certificate_with_policy(
         name: str,
         **kwargs: "**Any"
     ) -> Certificate:
-        """Gets information about a certificate, which includes information about the
-        certificate's policy.
+        """Gets a certificate and returns it's management policy as well.
 
 
-        Gets information about a specific certificate. This operation requires
-        the certificates/get permission. Does not accept the version of the certificate
-        as a parameter.
+        This operation requires the certificates/get permission. Does not accept the
+        version of the certificate as a parameter. If you wish to specify version, use
+        the get_certificate function and specify version.
 
         :param name: The name of the certificate in the given
          vault.
@@ -178,11 +177,10 @@ async def get_certificate(
             version: str,
             **kwargs: "**Any"
     ) -> Certificate:
-        """Gets information about a certificate.
+        """Gets a certificate by version without returning it's management policy.
 
-        Gets information about a specific certificate. This operation requires
-        the certificates/get permission. If you wish to not specify a version or to
-        get the certificate's policy as well, use the get_certificate_with_policy function.
+        If you wish to not specify a version or to get the certificate's policy as well,
+        use the get_certificate_with_policy function.
 
         :param name: The name of the certificate in the given
          vault.

sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/client.py

@@ -75,7 +75,7 @@ def create_certificate(
         :param tags: Application specific metadata in the form of key-value pairs.
         :type tags: dict(str, str)
         :returns: The created CertificateOperation
-        :rtype: ~azure.keyvault.certificates.models.CertificateOperation
+        :rtype: ~azure.core.polling.LROPoller
         :raises: ~azure.core.exceptions.HttpResponseError
 
         Example:
@@ -117,7 +117,7 @@ def create_certificate(
                                        subject_name="CN=DefaultPolicy",
                                        validity_in_months=12)
 
-        self._client.create_certificate(
+        create_certificate_operation = self._client.create_certificate(
             vault_base_url=self.vault_url,
             certificate_name=name,
             certificate_policy=policy._to_certificate_policy_bundle(),
@@ -136,7 +136,7 @@ def create_certificate(
         create_certificate_polling = CreateCertificatePoller(unknown_issuer=(policy.issuer_name.lower() == 'unknown'))
         return LROPoller(
             command,
-            "inprogress",
+            create_certificate_operation.status.lower(),
             None,
             create_certificate_polling
         )
@@ -145,12 +145,12 @@ def create_certificate(
     @distributed_trace
     def get_certificate_with_policy(self, name, **kwargs):
         # type: (str, **Any) -> Certificate
-        """Gets information about a certificate, which includes information about the
-        certificate's policy.
+        """Gets a certificate and returns it's management policy as well.
+
 
-        Gets information about a specific certificate. This operation requires
-        the certificates/get permission. Does not accept the version of the certificate
-        as a parameter.
+        This operation requires the certificates/get permission. Does not accept the
+        version of the certificate as a parameter. If you wish to specify version, use
+        the get_certificate function and specify version.
 
         :param name: The name of the certificate in the given
          vault.
@@ -178,12 +178,10 @@ def get_certificate_with_policy(self, name, **kwargs):
     @distributed_trace
     def get_certificate(self, name, version, **kwargs):
         # type: (str, str, **Any) -> Certificate
-        """Gets information about a certificate, which does not include the policy.
-        Version must be specified.
+        """Gets a certificate by version without returning it's management policy.
 
-        Gets information about a specific certificate. This operation requires
-        the certificates/get permission. If you wish to not specify a version or to
-        get the certificate's policy as well, use the get_certificate_with_policy function.
+        If you wish to not specify a version or to get the certificate's policy as well,
+        use the get_certificate_with_policy function.
 
         :param name: The name of the certificate in the given
          vault.

sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/models.py

@@ -1,8 +1,7 @@
-# --------------------------------------------------------------------------
-# Copyright (c) Microsoft Corporation. All rights reserved.
-# Licensed under the MIT License. See LICENSE.txt in the project root for
-# license information.
-# --------------------------------------------------------------------------
+# ------------------------------------
+# Copyright (c) Microsoft Corporation.
+# Licensed under the MIT License.
+# ------------------------------------
 # pylint:disable=too-many-lines
 
 from datetime import datetime