Skip to content

More useful exceptions for Key Vault errors #7086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chlowell merged 7 commits into from
Sep 18, 2019
Merged

More useful exceptions for Key Vault errors #7086

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
650c4b9
update docstrings
chlowell Sep 5, 2019
de5b384
ensure mapped exceptions surface Key Vault's error
chlowell Sep 11, 2019
e45b288
fix mypy errors
chlowell Sep 11, 2019
841ef7e
no thanks black, don't need these commas
chlowell Sep 11, 2019
dfaf05b
revert rebase mistake
chlowell Sep 18, 2019
ca673c8
copy shared code
chlowell Sep 18, 2019
c9f17fc
use error_map in certs methods
chlowell Sep 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
no thanks black, don't need these commas
  • Loading branch information
@chlowell
chlowell committed Sep 17, 2019
commit 841ef7e3cea81eb48d8a6ade19a5e038a9756b69
10 changes: 5 additions & 5 deletions sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/aio/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ async def create_key(
expires: Optional[datetime] = None,
not_before: Optional[datetime] = None,
tags: Optional[Dict[str, str]] = None,
**kwargs: "**Any",
**kwargs: "**Any"
) -> Key:
"""Create a key. If ``name`` is already in use, create a new version of the key. Requires the keys/create
permission.
Expand Down Expand Up @@ -120,7 +120,7 @@ async def create_rsa_key(
expires: Optional[datetime] = None,
not_before: Optional[datetime] = None,
tags: Optional[Dict[str, str]] = None,
**kwargs: "**Any",
**kwargs: "**Any"
) -> Key:
"""Create a new RSA key. If ``name`` is already in use, create a new version of the key. Requires the
keys/create permission.
Expand Down Expand Up @@ -171,7 +171,7 @@ async def create_ec_key(
expires: Optional[datetime] = None,
not_before: Optional[datetime] = None,
tags: Optional[Dict[str, str]] = None,
**kwargs: "**Any",
**kwargs: "**Any"
) -> Key:
"""Create a new elliptic curve key. If ``name`` is already in use, create a new version of the key. Requires
the keys/create permission.
Expand Down Expand Up @@ -407,7 +407,7 @@ async def update_key(
not_before: Optional[datetime] = None,
expires: Optional[datetime] = None,
tags: Optional[Dict[str, str]] = None,
**kwargs: "**Any",
**kwargs: "**Any"
) -> Key:
"""Change attributes of a key. Cannot change a key's cryptographic material. Requires the keys/update
permission.
Expand Down Expand Up @@ -513,7 +513,7 @@ async def import_key(
not_before: Optional[datetime] = None,
expires: Optional[datetime] = None,
tags: Optional[Dict[str, str]] = None,
**kwargs: "**Any",
**kwargs: "**Any"
) -> Key:
"""Import an externally created key. If ``name`` is already in use, import the key as a new version. Requires
the keys/import permission.
Expand Down