Skip to content

Skip Building on incompatible Python Versions #7160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scbedd merged 8 commits into from
Sep 11, 2019
Merged

Skip Building on incompatible Python Versions #7160

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5f9c939
removing universal wheel build. we only just met you
scbedd Sep 9, 2019
31b7619
first cut. need to work through the errors
scbedd Sep 9, 2019
9b4ca2e
save progress
scbedd Sep 9, 2019
e28f7b6
filtering by python version now!
scbedd Sep 9, 2019
edaeb62
common_tasks looks good.
scbedd Sep 10, 2019
a2dab0e
updating assumptions doc with proper grammar
scbedd Sep 10, 2019
881c0b1
double check CI builds. touch a couple dev_requirements files
scbedd Sep 10, 2019
07dd641
make certain that packaging is present
scbedd Sep 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
filtering by python version now!
  • Loading branch information
@scbedd
scbedd committed Sep 9, 2019
commit e28f7b6229b11993c24d9572430e2db97ae1acdb
6 changes: 4 additions & 2 deletions scripts/devops_tasks/common_tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"azure-servicefabric",
"azure-nspkg",
]
MAJOR_VERSION_REGEX = re.compile("Python\s\:\:\s(?<languageClassifier>[\d])[\.\d]*'")
MAJOR_VERSION_REGEX = re.compile("Python\s\:\:\s(?P<languageClassifier>[\d])[\.\d]*'")

def log_file(file_location, is_error=False):
with open(file_location, "r") as file:
Expand Down Expand Up @@ -106,7 +106,7 @@ def setup(*args, **kwargs):
def parse_major_classifiers(classifier_set):
major_versions = []
for classifier in classifier_set:
result = re.search()
result = re.search(MAJOR_VERSION_REGEX, classifier)
if result and result.group('languageClassifier'):
major_versions.append(result.group('languageClassifier'))
return set(major_versions)
Expand Down Expand Up @@ -154,6 +154,8 @@ def process_glob_string(glob_string, target_root_dir):

pkg_set_ci_filtered = filter_for_compatibility(allowed_package_set)
logging.info("Target packages after ci compatibility filter: {}".format(list(set(allowed_package_set) - set(pkg_set_ci_filtered))))

exit(1)
return sorted(pkg_set_ci_filtered)

def remove_omitted_packages(collected_directories):
Expand Down