Key Vault sample tidying #7224
Merged
Key Vault sample tidying #7224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
chlowell
added
the
Client
iscai-msft
reviewed
Sep 17, 2019
sdk/keyvault/azure-keyvault-certificates/samples/backup_restore_operations.py
Outdated
Show resolved
Hide resolved
sdk/keyvault/azure-keyvault-certificates/samples/backup_restore_operations.py
Outdated
Show resolved
Hide resolved
| finally: | ||
| print("\nrun_sample done") | ||
| # To ensure key is deleted on the server side. | ||
| print("\nDeleting keys...") |
Contributor
There was a problem hiding this comment.
For consistency I think it's better to be print("\n.. Deleting keys")
| finally: | ||
| print("\nrun_sample done") | ||
| # To ensure key is deleted on the server side. | ||
| print("\nDeleting EC Key...") |
Contributor
There was a problem hiding this comment.
Should be print("\n.. Deleting EC Key") for consistency
iscai-msft
approved these changes
Sep 18, 2019
YijunXieMS
pushed a commit
to YijunXieMS/azure-sdk-for-python
that referenced
this pull request
Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes across all the samples:
if __name__ == "__main__"from sync samples