Skip to content

Correct return type for list_secrets, _versions #7268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chlowell merged 1 commit into from
Sep 17, 2019
Merged

Correct return type for list_secrets, _versions #7268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
list_secrets, _versions return SecretAttributes
  • Loading branch information
@chlowell
chlowell committed Sep 13, 2019
commit de037f04d33b6350ff7666232dab2c1705cac20b
5 changes: 5 additions & 0 deletions sdk/keyvault/azure-keyvault-secrets/HISTORY.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
# Release History

## 4.0.0b4
### Fixes and improvements
- `list_secrets` and `list_secret_versions` return the correct type

## 4.0.0b3 (2019-09-11)
This release includes only internal changes.

Expand Down
4 changes: 2 additions & 2 deletions sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ def list_secrets(self, **kwargs):
return self._client.get_secrets(
self._vault_url,
maxresults=max_page_size,
cls=lambda objs: [DeletedSecret._from_secret_item(x) for x in objs],
cls=lambda objs: [SecretAttributes._from_secret_item(x) for x in objs],
**kwargs
)

Expand Down Expand Up @@ -216,7 +216,7 @@ def list_secret_versions(self, name, **kwargs):
self._vault_url,
name,
maxresults=max_page_size,
cls=lambda objs: [DeletedSecret._from_secret_item(x) for x in objs],
cls=lambda objs: [SecretAttributes._from_secret_item(x) for x in objs],
**kwargs
)

Expand Down