Skip to content

Conversation

@chlowell
Copy link
Member

@chlowell chlowell commented Oct 4, 2019

#7086 missed parts of SecretClient. This change also imports error_map in all client modules with an underscored name to avoid publicizing it.

@chlowell chlowell added KeyVault Client This issue points to a problem in the data-plane of the library. labels Oct 4, 2019
@chlowell chlowell self-assigned this Oct 4, 2019
@adxsdk6
Copy link

adxsdk6 commented Oct 4, 2019

Can one of the admins verify this patch?

@chlowell chlowell merged commit d484827 into Azure:master Oct 7, 2019
@chlowell chlowell deleted the error-map branch October 7, 2019 15:15
chlowell added a commit that referenced this pull request Oct 7, 2019
@chlowell chlowell restored the error-map branch October 7, 2019 16:16
iscai-msft pushed a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Oct 7, 2019
iscai-msft added a commit that referenced this pull request Oct 7, 2019
* switched vault_url to vault_endpoint across key vault

* moved enabled and tags to kwargs

* changed the name parameter for get_policy and update_policy to certificate_name

* updated changelog

* [Core] Updated release notes (#7627)

* Core doc fix (#7638)

* Fix azure-core examples

* Fix azure-core Readme

* Simplify doc

* Kill common.py file

* Remove tracing.ext

* update app config doc (#7618)

* update app config doc

* move match_condition to internal

* [AutoPR] netapp/resource-manager (#7092)

* Generated from 34d744550227bee7b380604d38fc1de6c9af6397 (#7089)

Update netapp.json

* changelog for netapp

* ANF-374 update for R5 RP version 2019-07-01 API

* ANF-374 update for R5 RP version 2019-07-01 API (#7460)

* ANF-374 update for R5 RP version 2019-07-01 API

* ANF-374 update for R5 RP version 2019-07-01 API

* ANF-374 update for R5 RP version 2019-07-01 API

* extending pypy timeout. (#7640)

* Eventhubs preview4 merge to master (#7605)

* [EventHubs] Eventhubs runtime metric (#7431)

* runtime metric init commit

* evenhubts-runtime-metric implementation

* Update code, and test and docstring

* Add example code

* Update property name

* Update name to last enqueued event properties

* Eventhubs remove iot and linkredirect (#7450)

* Remove iothub/link-redirect related code

* Remove self._running from consumer and producer

* Remove IoT related params "operation" and "device"

* Remove exception from close()

* add iterator long running test

* small bug fix

* small bug fix

* Fix connection properties bug and format

* Changed product to azure-eventhub in user agent

* Fix a type hint

* Improve stress script

* Print to console configurable

* small changes

* Disable tracking last enqueued event properties for uamqp 1.2.2

* use different consumer group

* fix an issue about consumer group

* fix an issue about consumer group

* Fix a get_properties bug

* [EventHubs] Performance improvement (#7533)

* performance improvement

* batch offset

* Review feedback

* Remove lazy parse in EventData

* Add annotation assertions

* Small fix for missing annotation initialization (#7575)

* Python EventHubs test code revamp (#7594)

* fix pylint error

* fix mypy error

* fix for 2.7

* fix for 2.7

* Sleep 300 seconds to test reconnect

* Remove Pypy from eventhub live test

* Remove Pypy from eventhub live test

* Add "Matrix:"

* Fix bug passing timeout in seconds to uamqp

* update checkpointstore HISTORY

* [EventHubs] Update documentations (#7603)

* Update docs

* Update iothub related description

* Docs update

* Small fix

* Small fix

* revert setup.py

* Resolve Global Install Errors (#7642)

* swapping all dev_requirements to leverage the non-develop mode. opencensus-tracing will fail if azure-core is installed in dev mode. all the rest of the tests are ok with using non-dev, so this seems to be a good compromise

* Setup core for unified pipelines. (#7577)

* Setup core for unified pipelines.

* Added open census to the core pipeline (can be released independently).

* Publish the packages artifact. (#7643)

* Enable template for unified templates. (#7644)

* Setup template for UP.

* Fixed service directory.

* ensure error_map is used consistently and correctly (#7637)

* switched vault_url to vault_endpoint across key vault

* ran black on keyvault

* reverted <<<HEAD additions to code

* got rid of black changes that broke python 3.5
YijunXieMS pushed a commit to YijunXieMS/azure-sdk-for-python that referenced this pull request Oct 9, 2019
YijunXieMS pushed a commit to YijunXieMS/azure-sdk-for-python that referenced this pull request Oct 9, 2019
* switched vault_url to vault_endpoint across key vault

* moved enabled and tags to kwargs

* changed the name parameter for get_policy and update_policy to certificate_name

* updated changelog

* [Core] Updated release notes (Azure#7627)

* Core doc fix (Azure#7638)

* Fix azure-core examples

* Fix azure-core Readme

* Simplify doc

* Kill common.py file

* Remove tracing.ext

* update app config doc (Azure#7618)

* update app config doc

* move match_condition to internal

* [AutoPR] netapp/resource-manager (Azure#7092)

* Generated from 34d744550227bee7b380604d38fc1de6c9af6397 (Azure#7089)

Update netapp.json

* changelog for netapp

* ANF-374 update for R5 RP version 2019-07-01 API

* ANF-374 update for R5 RP version 2019-07-01 API (Azure#7460)

* ANF-374 update for R5 RP version 2019-07-01 API

* ANF-374 update for R5 RP version 2019-07-01 API

* ANF-374 update for R5 RP version 2019-07-01 API

* extending pypy timeout. (Azure#7640)

* Eventhubs preview4 merge to master (Azure#7605)

* [EventHubs] Eventhubs runtime metric (Azure#7431)

* runtime metric init commit

* evenhubts-runtime-metric implementation

* Update code, and test and docstring

* Add example code

* Update property name

* Update name to last enqueued event properties

* Eventhubs remove iot and linkredirect (Azure#7450)

* Remove iothub/link-redirect related code

* Remove self._running from consumer and producer

* Remove IoT related params "operation" and "device"

* Remove exception from close()

* add iterator long running test

* small bug fix

* small bug fix

* Fix connection properties bug and format

* Changed product to azure-eventhub in user agent

* Fix a type hint

* Improve stress script

* Print to console configurable

* small changes

* Disable tracking last enqueued event properties for uamqp 1.2.2

* use different consumer group

* fix an issue about consumer group

* fix an issue about consumer group

* Fix a get_properties bug

* [EventHubs] Performance improvement (Azure#7533)

* performance improvement

* batch offset

* Review feedback

* Remove lazy parse in EventData

* Add annotation assertions

* Small fix for missing annotation initialization (Azure#7575)

* Python EventHubs test code revamp (Azure#7594)

* fix pylint error

* fix mypy error

* fix for 2.7

* fix for 2.7

* Sleep 300 seconds to test reconnect

* Remove Pypy from eventhub live test

* Remove Pypy from eventhub live test

* Add "Matrix:"

* Fix bug passing timeout in seconds to uamqp

* update checkpointstore HISTORY

* [EventHubs] Update documentations (Azure#7603)

* Update docs

* Update iothub related description

* Docs update

* Small fix

* Small fix

* revert setup.py

* Resolve Global Install Errors (Azure#7642)

* swapping all dev_requirements to leverage the non-develop mode. opencensus-tracing will fail if azure-core is installed in dev mode. all the rest of the tests are ok with using non-dev, so this seems to be a good compromise

* Setup core for unified pipelines. (Azure#7577)

* Setup core for unified pipelines.

* Added open census to the core pipeline (can be released independently).

* Publish the packages artifact. (Azure#7643)

* Enable template for unified templates. (Azure#7644)

* Setup template for UP.

* Fixed service directory.

* ensure error_map is used consistently and correctly (Azure#7637)

* switched vault_url to vault_endpoint across key vault

* ran black on keyvault

* reverted <<<HEAD additions to code

* got rid of black changes that broke python 3.5
kristapratico pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Oct 9, 2019
kristapratico pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Oct 9, 2019
* switched vault_url to vault_endpoint across key vault

* moved enabled and tags to kwargs

* changed the name parameter for get_policy and update_policy to certificate_name

* updated changelog

* [Core] Updated release notes (Azure#7627)

* Core doc fix (Azure#7638)

* Fix azure-core examples

* Fix azure-core Readme

* Simplify doc

* Kill common.py file

* Remove tracing.ext

* update app config doc (Azure#7618)

* update app config doc

* move match_condition to internal

* [AutoPR] netapp/resource-manager (Azure#7092)

* Generated from 34d744550227bee7b380604d38fc1de6c9af6397 (Azure#7089)

Update netapp.json

* changelog for netapp

* ANF-374 update for R5 RP version 2019-07-01 API

* ANF-374 update for R5 RP version 2019-07-01 API (Azure#7460)

* ANF-374 update for R5 RP version 2019-07-01 API

* ANF-374 update for R5 RP version 2019-07-01 API

* ANF-374 update for R5 RP version 2019-07-01 API

* extending pypy timeout. (Azure#7640)

* Eventhubs preview4 merge to master (Azure#7605)

* [EventHubs] Eventhubs runtime metric (Azure#7431)

* runtime metric init commit

* evenhubts-runtime-metric implementation

* Update code, and test and docstring

* Add example code

* Update property name

* Update name to last enqueued event properties

* Eventhubs remove iot and linkredirect (Azure#7450)

* Remove iothub/link-redirect related code

* Remove self._running from consumer and producer

* Remove IoT related params "operation" and "device"

* Remove exception from close()

* add iterator long running test

* small bug fix

* small bug fix

* Fix connection properties bug and format

* Changed product to azure-eventhub in user agent

* Fix a type hint

* Improve stress script

* Print to console configurable

* small changes

* Disable tracking last enqueued event properties for uamqp 1.2.2

* use different consumer group

* fix an issue about consumer group

* fix an issue about consumer group

* Fix a get_properties bug

* [EventHubs] Performance improvement (Azure#7533)

* performance improvement

* batch offset

* Review feedback

* Remove lazy parse in EventData

* Add annotation assertions

* Small fix for missing annotation initialization (Azure#7575)

* Python EventHubs test code revamp (Azure#7594)

* fix pylint error

* fix mypy error

* fix for 2.7

* fix for 2.7

* Sleep 300 seconds to test reconnect

* Remove Pypy from eventhub live test

* Remove Pypy from eventhub live test

* Add "Matrix:"

* Fix bug passing timeout in seconds to uamqp

* update checkpointstore HISTORY

* [EventHubs] Update documentations (Azure#7603)

* Update docs

* Update iothub related description

* Docs update

* Small fix

* Small fix

* revert setup.py

* Resolve Global Install Errors (Azure#7642)

* swapping all dev_requirements to leverage the non-develop mode. opencensus-tracing will fail if azure-core is installed in dev mode. all the rest of the tests are ok with using non-dev, so this seems to be a good compromise

* Setup core for unified pipelines. (Azure#7577)

* Setup core for unified pipelines.

* Added open census to the core pipeline (can be released independently).

* Publish the packages artifact. (Azure#7643)

* Enable template for unified templates. (Azure#7644)

* Setup template for UP.

* Fixed service directory.

* ensure error_map is used consistently and correctly (Azure#7637)

* switched vault_url to vault_endpoint across key vault

* ran black on keyvault

* reverted <<<HEAD additions to code

* got rid of black changes that broke python 3.5
fengzhou-msft pushed a commit that referenced this pull request Nov 5, 2019
* switched vault_url to vault_endpoint across key vault

* moved enabled and tags to kwargs

* changed the name parameter for get_policy and update_policy to certificate_name

* updated changelog

* [Core] Updated release notes (#7627)

* Core doc fix (#7638)

* Fix azure-core examples

* Fix azure-core Readme

* Simplify doc

* Kill common.py file

* Remove tracing.ext

* update app config doc (#7618)

* update app config doc

* move match_condition to internal

* [AutoPR] netapp/resource-manager (#7092)

* Generated from 34d744550227bee7b380604d38fc1de6c9af6397 (#7089)

Update netapp.json

* changelog for netapp

* ANF-374 update for R5 RP version 2019-07-01 API

* ANF-374 update for R5 RP version 2019-07-01 API (#7460)

* ANF-374 update for R5 RP version 2019-07-01 API

* ANF-374 update for R5 RP version 2019-07-01 API

* ANF-374 update for R5 RP version 2019-07-01 API

* extending pypy timeout. (#7640)

* Eventhubs preview4 merge to master (#7605)

* [EventHubs] Eventhubs runtime metric (#7431)

* runtime metric init commit

* evenhubts-runtime-metric implementation

* Update code, and test and docstring

* Add example code

* Update property name

* Update name to last enqueued event properties

* Eventhubs remove iot and linkredirect (#7450)

* Remove iothub/link-redirect related code

* Remove self._running from consumer and producer

* Remove IoT related params "operation" and "device"

* Remove exception from close()

* add iterator long running test

* small bug fix

* small bug fix

* Fix connection properties bug and format

* Changed product to azure-eventhub in user agent

* Fix a type hint

* Improve stress script

* Print to console configurable

* small changes

* Disable tracking last enqueued event properties for uamqp 1.2.2

* use different consumer group

* fix an issue about consumer group

* fix an issue about consumer group

* Fix a get_properties bug

* [EventHubs] Performance improvement (#7533)

* performance improvement

* batch offset

* Review feedback

* Remove lazy parse in EventData

* Add annotation assertions

* Small fix for missing annotation initialization (#7575)

* Python EventHubs test code revamp (#7594)

* fix pylint error

* fix mypy error

* fix for 2.7

* fix for 2.7

* Sleep 300 seconds to test reconnect

* Remove Pypy from eventhub live test

* Remove Pypy from eventhub live test

* Add "Matrix:"

* Fix bug passing timeout in seconds to uamqp

* update checkpointstore HISTORY

* [EventHubs] Update documentations (#7603)

* Update docs

* Update iothub related description

* Docs update

* Small fix

* Small fix

* revert setup.py

* Resolve Global Install Errors (#7642)

* swapping all dev_requirements to leverage the non-develop mode. opencensus-tracing will fail if azure-core is installed in dev mode. all the rest of the tests are ok with using non-dev, so this seems to be a good compromise

* Setup core for unified pipelines. (#7577)

* Setup core for unified pipelines.

* Added open census to the core pipeline (can be released independently).

* Publish the packages artifact. (#7643)

* Enable template for unified templates. (#7644)

* Setup template for UP.

* Fixed service directory.

* ensure error_map is used consistently and correctly (#7637)

* switched vault_url to vault_endpoint across key vault

* ran black on keyvault

* reverted <<<HEAD additions to code

* got rid of black changes that broke python 3.5
@chlowell chlowell deleted the error-map branch January 13, 2020 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client This issue points to a problem in the data-plane of the library. KeyVault

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants