Skip to content

Conversation

@bryevdv
Copy link
Contributor

@bryevdv bryevdv commented Nov 19, 2019

cc @annatisch @mayurid

This PR makes the following updates to the (non-multi-master) cosmos samples based on the spreadsheet:

  • removes trailing whitespace throughout (AFAIK linter now requires this)
  • renames "collection" -> "container" throughout
  • renames for "offer throughput" and "performance tier" throughout.

I'd note that there are still header and parameters "offerThroughput" and offer_throughput`. Updating these would require API / service changes, so I did not touch them.

Commits are self-contained and may be easier to review individually.

All affected examples were run to confirm proper execution.

The rest of the spreadsheet it a bit vague/confusing to me, e.g. not sure what the specific goals are with "New sample needed". Any clarifications are appreciated.

@adxsdk6
Copy link

adxsdk6 commented Nov 19, 2019

Can one of the admins verify this patch?

Copy link
Member

@annatisch annatisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@bryevdv bryevdv merged commit 53dd8e2 into Azure:master Nov 22, 2019
@bryevdv bryevdv deleted the bryanv/cosmos_samples_upates branch November 22, 2019 18:30
openapi-sdkautomation-test bot pushed a commit to openapi-env-test/azure-sdk-for-python that referenced this pull request Mar 24, 2020
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs into keyvault_multiapi_readme

* 'master' of https://github.com/Azure/azure-rest-api-specs: (101 commits)
  add cli.md for automation (Azure#8411)
  adjust assignment (Azure#8782)
  Remove Microsoft.Backup.Admin 2016-05-01 API version (Azure#8588)
  Updating global setting in PostgreSQL/MySQL readme file (Azure#8777)
  update package name and output folder in readme.typescript.md (Azure#8764)
  add package-2019-12 python define (Azure#8769)
  Fix Parameter Description for validate resource move (Azure#8524)
  Edit pass for GA swagger (Azure#8759)
  Update proxy.json (Azure#8596)
  Model enums that may change in the future as strings (Azure#8760)
  Add api-version 2019-11-01 for resources/subscriptions (Azure#8728)
  regenerated all-api-versions
  PrivateLinkResources for Microsoft.Automation (Azure#8369)
  add cli.md for serialconsole (Azure#8401)
  add cli.md for mariadb (Azure#8466)
  [Computer Vision] Create CV API v3.0-preview (Azure#7402)
  Publish Microsoft.ContainerService api-version 2020-03-01 (Azure#8756)
  Update swagger based on auto-gen process change. (Azure#8766)
  add assignment-bot config (Azure#8716)
  add tag package-2019-12 to batch (Azure#8751)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants