Add proxy policy to credential pipelines#8945
Merged
chlowell merged 4 commits intoAzure:masterfrom Dec 5, 2019
Merged
Conversation
chlowell
added
Client
bryevdv
previously approved these changes
Dec 3, 2019
Contributor
bryevdv
left a comment
bryevdv
left a comment
There was a problem hiding this comment.
LGTM only tiny suggestion: pulling out the lambdas to send functions would let the sync/async test code be structurally more similar
bryevdv
approved these changes
Dec 4, 2019
annatisch
pushed a commit
to annatisch/azure-sdk-for-python
that referenced
this pull request
Dec 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Primary purpose here is to ensure
ProxyPolicyis added to all default pipelines. While I was at it I added tests verifying credential constructors respect the 'policies' keyword argument.