Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Conversation

@vishrutshah
Copy link
Contributor

@vishrutshah vishrutshah commented Sep 9, 2017

Regarding #958

@veronicagg
Copy link
Contributor

@vishrutshah question: the change that's marked as reverted above, takes me automatic PR
#934 that comes from Azure/azure-rest-api-specs#1574 This PR doesn't seem to contain the ResourceUpdate changes, what am I missing?

@vishrutshah
Copy link
Contributor Author

@veronicagg That's a right question but as i was just making commits to unblock my task this PR appears here. Could you please reivew https://github.com/Azure/azure-sdk-for-ruby/pull/959/files#diff-12caea728ed994cf224b6432d02d995eR11 first and see if I missed anything here. If i missed it should be there as well. Thanks!

@veronicagg
Copy link
Contributor

Rest looks good to me. Could you update our instructions on the release process? now that we have the Autorest.Ruby repo?

@vishrutshah
Copy link
Contributor Author

vishrutshah commented Sep 11, 2017

Below is the remaining checklist for me:

Copy link
Contributor

@veronicagg veronicagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vishrutshah
Copy link
Contributor Author

Thanks for the review!! I'll wait for @sarangan12 to go over this as well to make sure things looks good.

@sarangan12
Copy link
Contributor

LGTM

@vishrutshah
Copy link
Contributor Author

Thanks @sarangan12 for taking a look.

@vishrutshah vishrutshah changed the title [In Review] Prepare to release azure_mgmt_* version 0.12.0 [azure_mgmt_*] Prepare to release azure_mgmt_* version 0.12.0 Sep 12, 2017
@vishrutshah vishrutshah merged commit 2833a3f into Azure:master Sep 12, 2017
@vishrutshah vishrutshah deleted the arm-0.12.0 branch September 12, 2017 00:22
@veronicagg veronicagg mentioned this pull request Sep 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants