-
Notifications
You must be signed in to change notification settings - Fork 247
[azure_mgmt_*] Prepare to release azure_mgmt_* version 0.12.0 #962
Conversation
|
@vishrutshah question: the change that's marked as reverted above, takes me automatic PR |
|
@veronicagg That's a right question but as i was just making commits to unblock my task this PR appears here. Could you please reivew https://github.com/Azure/azure-sdk-for-ruby/pull/959/files#diff-12caea728ed994cf224b6432d02d995eR11 first and see if I missed anything here. If i missed it should be there as well. Thanks! |
|
Rest looks good to me. Could you update our instructions on the release process? now that we have the Autorest.Ruby repo? |
|
Below is the remaining checklist for me:
|
veronicagg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thanks for the review!! I'll wait for @sarangan12 to go over this as well to make sure things looks good. |
|
LGTM |
|
Thanks @sarangan12 for taking a look. |
Regarding #958
azure_mgmt_traffic_managerdue to Code changes to remove condition to check for known primary type autorest.ruby#7azure_mgmt_webdue to [AutoRest.Ruby] Inheritance usage of "Resource" is broken #9570.12.00.12.0azure_mgmt_computgem.gemspecfile to depend onms_rest_azureversion~>0.9.0AutoRest.Rubygenerator