-
Notifications
You must be signed in to change notification settings - Fork 324
Sync eng/common directory with azure-sdk-tools for PR 12734 #3280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the cspell package configuration to use a scoped package name and pins the cspell dependency to an exact version. The changes improve dependency management by removing the version range specifier and making the package private.
Key changes:
- Renamed package from
cspell-version-pinto@azure-tools/cspell - Changed cspell dependency from
^9.2.1to exact version9.2.1 - Added
"private": trueto package.json
Reviewed Changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| eng/common/spelling/package.json | Updated package name to scoped @azure-tools/cspell, added private flag, and pinned cspell to exact version |
| eng/common/spelling/package-lock.json | Synchronized lockfile with package.json changes for name and version pinning |
Files not reviewed (1)
- eng/common/spelling/package-lock.json: Language not supported
| { | ||
| "name": "cspell-version-pin", | ||
| "name": "@azure-tools/cspell", | ||
| "version": "1.0.0", |
Copilot
AI
Oct 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version field in package-lock.json should match the version in package.json. However, package.json no longer includes an explicit version field after adding "private": true. For private packages, it's recommended to either keep the version field in package.json for consistency or remove it from package-lock.json as well.
| "version": "1.0.0", |
|
Hi @azure-sdk. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
|
Hi @azure-sdk. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing |
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#12734 See eng/common workflow