Skip to content

Use correct leading slash in common.ps1 repo root resolution #10694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
benbp merged 2 commits into from
Jun 3, 2025
Merged

Use correct leading slash in common.ps1 repo root resolution #10694

benbp merged 2 commits into from
Jun 3, 2025

Conversation

@benbp
Copy link
Member

@benbp benbp commented May 20, 2025 •
edited
Loading

Use correct leading slash in common.ps1 repo root resolution. You need a leading slash after $PSScriptRoot, hence why the current code has to use 4 .. instead of 3 (the first ends up getting ignored).

Copilot AI review requested due to automatic review settings May 20, 2025 20:58
@benbp benbp added the Central-EngSys This issue is owned by the Engineering System team. label May 20, 2025
@benbp benbp self-assigned this May 20, 2025
@benbp benbp requested a review from a team as a code owner May 20, 2025 20:58
@benbp benbp added the Central-EngSys This issue is owned by the Engineering System team. label May 20, 2025
@benbp benbp requested a review from weshaggard May 20, 2025 20:58
@benbp benbp moved this from 🤔 Triage to 🔬 Dev in PR in Azure SDK EngSys 📆🎇 May 20, 2025
@benbp benbp mentioned this pull request May 20, 2025
Merged
Copilot AI reviewed May 20, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

The PR fixes the repository root resolution in common.ps1 by correcting the number of parent traversals and standardizing the path string.

  • Adjusts the relative path from four levels up to three to correctly target the repo root
  • Switches from backslash-based ..\..\..\.. notation to forward-slash ../../../ notation

@azure-sdk
Copy link
Collaborator

azure-sdk commented May 20, 2025

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

This was referenced May 21, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
weshaggard
weshaggard reviewed May 21, 2025
View reviewed changes
@azure-sdk
Copy link
Collaborator

azure-sdk commented Jun 2, 2025

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@benbp benbp enabled auto-merge (squash) June 3, 2025 20:22
azure-sdk added a commit to Azure/azure-sdk-for-js that referenced this pull request Jun 3, 2025
@azure-sdk @benbp @weshaggard
Sync eng/common directory with azure-sdk-tools for PR 10694 (#34493)
40b2716 
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#10694 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

---------

Co-authored-by: Ben Broderick Phillips <[email protected]>
Co-authored-by: Wes Haggard <[email protected]>
@benbp benbp merged commit 5e58310 into main Jun 3, 2025
11 checks passed
@benbp benbp deleted the benbp/fix-common-resolve branch June 3, 2025 20:28
@kurtzeborn kurtzeborn moved this from 🔬 Dev in PR to 🎊 Closed in Azure SDK EngSys 📆🎇 Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@weshaggard weshaggard weshaggard approved these changes

Assignees

@benbp benbp

Labels

Central-EngSys This issue is owned by the Engineering System team.

Projects

Azure SDK EngSys 📆🎇
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@benbp @azure-sdk @weshaggard