Read issue routing from codeowners #1084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ach service folder. This will allow us to consolidate the data in the codeowners file with the one in the WIKI.
… services that don't have the code in the repo
Member
|
@chidozieononiwu this update will likely impact your PR #981. |
weshaggard
reviewed
Oct 9, 2020
tools/CreateRuleFabricBot/CreateRuleFabricBot/Helpers/CodeOwnersFile.cs
Outdated
Show resolved
Hide resolved
weshaggard
reviewed
Oct 9, 2020
tools/CreateRuleFabricBot/CreateRuleFabricBot/Helpers/CodeOwnersFile.cs
Outdated
Show resolved
Hide resolved
weshaggard
reviewed
Oct 9, 2020
tools/CreateRuleFabricBot/CreateRuleFabricBot/Helpers/CodeOwnersFile.cs
Outdated
Show resolved
Hide resolved
Add tests and ensure that comments inline with the folder name are allowed.
weshaggard
approved these changes
Oct 9, 2020
|
Hello @AlexGhiondea! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
benbp
pushed a commit
that referenced
this pull request
Dec 1, 2020
This is the first step towards the unification of the data sources for issue routing and PR labels for the Azure SDK repos. We are going to add a comment in the CODEOWNERS file above the path representing the service with the set of labels that, when present, will ensure that the owners get tagged in the issue with those labels.
sima-zhu
pushed a commit
to sima-zhu/azure-sdk-tools
that referenced
this pull request
Dec 3, 2020
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step towards the unification of the data sources for issue routing and PR labels for the Azure SDK repos.
We are going to add a comment in the CODEOWNERS file above the path representing the service with the set of labels that, when present, will ensure that the owners get tagged in the issue with those labels.