Skip to content

Conversation

@weshaggard
Copy link
Member

To help debug matrix filters and other generation issues add additional logging.

To help debug matrix filters and other generation issues add additional logging.
Copilot AI review requested due to automatic review settings July 1, 2025 21:56
@weshaggard weshaggard requested a review from a team as a code owner July 1, 2025 21:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances visibility into matrix generation by adding detailed logging of configuration inputs and parameters.

  • Dot-sources a shared logging.ps1 and wraps parameter dumps in a log group
  • Captures the raw config file contents separately for output
  • Switches matrix output from Write-Output to Write-Host with a preceding label

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@weshaggard
Copy link
Member Author

@benbp I'm really surprised you didn't already have some logging for this as it can be difficult to see all the values by going through the templates.

azure-sdk added a commit to Azure/azure-sdk-for-js that referenced this pull request Jul 2, 2025
@weshaggard weshaggard merged commit 4751808 into main Jul 2, 2025
10 checks passed
@weshaggard weshaggard deleted the weshaggard-patch-1 branch July 2, 2025 20:18
@benbp
Copy link
Member

benbp commented Jul 8, 2025

@benbp I'm really surprised you didn't already have some logging for this as it can be difficult to see all the values by going through the templates.

@weshaggard I've always relied on the download full yaml to see exactly what's passed to Create-JobMatrix.ps1 as it is much faster than running a pipeline to get the values.

Looks like yaml download is also available after the fact now for pipeline runs:

image

@weshaggard
Copy link
Member Author

Well now it is also in the pipeline logs :)

benbp pushed a commit to benbp/azure-sdk-tools that referenced this pull request Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants