Force entrylock on matcher value
#11515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wait on the EntryLock for the session so that when tests actually start they're seeing the same value for the matcher
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds thread-safe access to setting a matcher for recording sessions by introducing an entry lock around the matcher assignment operation.
- Converts
SetMatcherForRecordingfrom synchronous to asynchronous to support async lock operations - Adds proper lock acquisition and release around the critical section where the custom matcher is set
Comments suppressed due to low confidence (1)
tools/test-proxy/Azure.Sdk.Tools.TestProxy/RecordingHandler.cs:1107
- Missing opening brace after the finally statement. The code should be
finally {to properly open the finally block.
finally
benbp
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As soon as I saw the error I thought I had missed something.