Support single line of command config #12023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for defining single-line commands inline in the configuration file for the SDK generation process. The changes make the path property optional in RunOptions and introduce a new command property as an alternative.
- Made
pathproperty optional inRunOptionstype definition - Added
commandproperty to support inline command execution - Added validation to ensure either
pathorcommandis provided
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tools/spec-gen-sdk/src/types/SwaggerToSdkConfig.ts | Updated RunOptions type to make path optional and add command property |
| tools/spec-gen-sdk/src/types/SwaggerToSdkConfigSchema.json | Added command field to schema and removed path from required fields |
| tools/spec-gen-sdk/src/utils/runScript.ts | Added validation to throw error when path is not provided |
| tools/spec-gen-sdk/test/utils/runScript.test.ts | Added test case for validation when path is missing |
| tools/spec-gen-sdk/package.json | Version bump to 0.9.2 |
| tools/spec-gen-sdk/CHANGELOG.md | Added changelog entry for the new feature |
Files not reviewed (1)
- tools/spec-gen-sdk/package-lock.json: Language not supported
weshaggard
approved these changes
Sep 10, 2025
samvaity
pushed a commit
that referenced
this pull request
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pathas optional configcommandtoRunOptionstypeThis is to support defining single line of command inline of the config file for build SDK process.
Two related PRs:
Azure/azure-sdk-for-java#46647
Azure/azure-sdk-for-net#52546