Skip to content

Conversation

@benbp
Copy link
Member

@benbp benbp commented Nov 15, 2021

Currently the sparse checkout of the service directory happens to work because it will match on the directory name, e.g.
git sparse-checkout add keyvault will end up checking out sdk/keyvault. However, some service directories (such as
in azure-sdk-for-go) are now multiple directory segments, e.g. keyvault/azkeys. This breaks the git sparse checkout
matching, so to fix the service directory can be updated to an exact path sdk/<service directory>.

@benbp benbp requested a review from a team as a code owner November 15, 2021 22:42
@benbp benbp added the Central-EngSys This issue is owned by the Engineering System team. label Nov 15, 2021
@benbp benbp self-assigned this Nov 15, 2021
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@ghost
Copy link

ghost commented Nov 16, 2021

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 463ba87 into main Nov 16, 2021
@ghost ghost deleted the benbp/sparse-service-dir branch November 16, 2021 18:14
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants