Support staging URl to run detect API changes in test env #2875
Conversation
praveenkuttappan
requested review from
benbp,
sima-zhu and
weshaggard
as code owners
|
@weidongxu-microsoft This PR is required for you to integrate SDK automation from test pipeline. Once this PR is merged, you can set pipeline variable "ApiChangeDetectRequestUrl" to pass staging instance URL so SDK automation test pipeline can create review in test env. I will send you details offline. |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
@benbp @weshaggard Can you please review this change and approve? We need this PR to support staging or any test API view environment to create API review from a test pipeline. Specifically required for SDK automation demo next week. Thanks //cc: @weidongxu-microsoft |
| $apiChangeDetectRequestUrl = "https://apiview.dev/PullRequest/DetectApiChanges" | ||
| echo "##vso[task.setvariable variable=ApiChangeDetectRequestUrl]$apiChangeDetectRequestUrl" | ||
| displayName: "Set API change detect request URL" | ||
| condition: eq(variables['ApiChangeDetectRequestUrl'], '') |
There was a problem hiding this comment.
Have you tried setting this as the default in a variables block in this file? It would be simpler.
variables:
ApiChangeDetectRequestUrl: <value that gets overwritten>
Also, how should a pipeline template caller override this variable? Would it be easier to use a devops parameter and default it instead?
parameters:
ApiChangeDetectRequestUrl: <url>
There was a problem hiding this comment.
Why didn't we override existing param to support different URL from caller YAML:
Caller pipeline yaml is same in test as well as main repo since it is a copy of azure sdk language repos. Even if we modify caller pipeline then it will get overridden with changes from main branch.
pipeline doesn't have any step level variable. We will need to set this as job level variable for all languages in caller side. Devops is failing with incorrect yaml when variables is added in this block.
Caller pipeline can setup pipeline queue time variable whenever we want to test manually against different instance. This change is to support testing API change detection using non prod APIView instance for demo or for manual testing.
|
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
|
@dw511214992 here is the right Wei Dong :-) |
4 participants
Currently API detection step sends request to APIView production instance. This PR is to support alternate environment to test API change detection from test pipeline (specially to test SDK automation).