Support creating test resources based on logged in user #7580
Conversation
JoshLove-msft
requested review from
benbp,
chidozieononiwu,
heaths and
weshaggard
as code owners
JoshLove-msft
force-pushed
the
new-test-resources-user-auth
branch
from
d06a10e to
aaa5959
Compare
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
weshaggard
left a comment
weshaggard
left a comment
There was a problem hiding this comment.
Looks reasonable to me but I'm going to defer to @benbp who has more history with this script.
benbp
left a comment
benbp
left a comment
There was a problem hiding this comment.
LGTM with a parameter name change
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#7580 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: jolov <[email protected]>
8 participants
The way that this can be integrated into language test frameworks is by assuming that if no client secret is populated, a user credential should be created instead of a client secret credential.
Also, downstream test-resources templates should remove testApplicationSecret from the parameter list to avoid being prompted for it (assuming it is not actually necessary).