Skip to content

Fix role assignment for user auth #7584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JoshLove-msft merged 3 commits into from
Jan 26, 2024
Merged

Fix role assignment for user auth #7584

JoshLove-msft merged 3 commits into from
Jan 26, 2024

Conversation

@JoshLove-msft
Copy link
Member

@JoshLove-msft JoshLove-msft commented Jan 25, 2024 •
edited
Loading

Manually tested:

  • Create with new SP
  • Create with cached SP
  • Create with user auth

@JoshLove-msft JoshLove-msft requested review from benbp, heaths, jsquire and weshaggard and removed request for benbp, heaths and weshaggard January 25, 2024 00:54
@azure-sdk
Copy link
Collaborator

azure-sdk commented Jan 25, 2024

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

jsquire
jsquire approved these changes Jan 25, 2024
View reviewed changes
@azure-sdk
Copy link
Collaborator

azure-sdk commented Jan 25, 2024

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

heaths
heaths approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits to look more appealing, but otherwise LGTM.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Jan 25, 2024

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

This was referenced Jan 25, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
azure-sdk added a commit to Azure/azure-sdk-for-js that referenced this pull request Jan 25, 2024
@azure-sdk @JoshLove-msft @heaths
Sync eng/common directory with azure-sdk-tools for PR 7584 (#28375)
8c002aa 
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#7584 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

---------

Co-authored-by: jolov <[email protected]>
Co-authored-by: JoshLove-msft <[email protected]>
Co-authored-by: Heath Stewart <[email protected]>
@JoshLove-msft JoshLove-msft merged commit f23c1aa into Azure:main Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsquire jsquire jsquire approved these changes

@benbp benbp benbp approved these changes

@heaths heaths heaths approved these changes

@weshaggard weshaggard Awaiting requested review from weshaggard

@christothes christothes Awaiting requested review from christothes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JoshLove-msft @azure-sdk @jsquire @benbp @heaths