Skip to content

Fix case-sensitive spelling in scripts that get deployed to C++ repo #7665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
antkmsft merged 2 commits into from
Feb 14, 2024
Merged

Fix case-sensitive spelling in scripts that get deployed to C++ repo #7665

antkmsft merged 2 commits into from
Feb 14, 2024

Conversation

@antkmsft
Copy link
Member

@antkmsft antkmsft commented Feb 12, 2024 •
edited
Loading

For C++-only fixes, see Azure/azure-sdk-for-cpp#5346

@antkmsft antkmsft added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. C++ C++ Language labels Feb 12, 2024
@antkmsft antkmsft mentioned this pull request Feb 12, 2024
Merged
@antkmsft antkmsft requested a review from danieljurek February 12, 2024 17:27
@azure-sdk
Copy link
Collaborator

azure-sdk commented Feb 12, 2024

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

danieljurek
danieljurek reviewed Feb 12, 2024
View reviewed changes
@azure-sdk
Copy link
Collaborator

azure-sdk commented Feb 12, 2024

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

azure-sdk commented Feb 12, 2024

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@antkmsft
Copy link
Member Author

antkmsft commented Feb 13, 2024 •
edited
Loading

Please let me know if in the future you would want me to self-approve "create sync PRs" CI step after I get your approvals, or if you typically prefer to do it by your team.

This was referenced Feb 13, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
antkmsft added a commit to Azure/azure-sdk-for-js that referenced this pull request Feb 14, 2024
@azure-sdk @antkmsft
Sync eng/common directory with azure-sdk-tools for PR 7665 (#28567)
c43d2a0 
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#7665 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

Co-authored-by: Anton Kolesnyk <[email protected]>
@antkmsft antkmsft merged commit 6f871ed into Azure:main Feb 14, 2024
@antkmsft antkmsft deleted the eng-spelling branch February 14, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benbp benbp benbp approved these changes

@danieljurek danieljurek danieljurek approved these changes

@konrad-jamrozik konrad-jamrozik Awaiting requested review from konrad-jamrozik

@weshaggard weshaggard Awaiting requested review from weshaggard

Assignees

No one assigned

Labels

C++ C++ Language Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@antkmsft @azure-sdk @benbp @danieljurek