Deal with friends from multiple classes #8037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RickWinter
approved these changes
Apr 9, 2024
| clang::FriendDecl const* friendDecl, | ||
| std::string const& parentNodeNavigationId) | ||
| { | ||
| std::string navigationId = parentNodeNavigationId + "_friend_"; |
Member
There was a problem hiding this comment.
Can the parentNodeNavigationId be ""? Can we assert these premises.
Member
Author
There was a problem hiding this comment.
It cannot be empty, I'll add an error message if it is.
| return navigationId; | ||
| } | ||
|
|
||
| static std::string GetNavigationId( |
| friendDecl->dump(llvm::outs()); | ||
| } | ||
| } | ||
| return navigationId; |
Member
There was a problem hiding this comment.
If you end up in the final else of the initial if/else then you could end up with navigationId being <parentNodeId>_friend_. Is a navigationId ending in "_" a valid format?
Member
Author
There was a problem hiding this comment.
All strings are valid, the only restriction is that the names must be unique.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.