Skip to content

Add debug non-safe points to Java profiling #8089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alzimmermsft merged 3 commits into from
Apr 15, 2024
Merged

Add debug non-safe points to Java profiling #8089

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
49b880d
Add debug non-safe points to Java profiling
alzimmermsft Apr 15, 2024
459240f
Merge branch 'main' into UpdateJavaProfiling
alzimmermsft Apr 15, 2024
e58cfa3
Move new config to correct spot
alzimmermsft Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/perf-automation/Azure.Sdk.Tools.PerfAutomation/Java.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ public override async Task<IterationResult> RunAsync(
if (profile)
{
var profileOutputPath = Path.GetFullPath(Path.Combine(Util.GetProfileDirectory(WorkingDirectory), $"{testName}_{profileCount++}.jfr"));
profilingConfig = $"-XX:StartFlightRecording=filename={profileOutputPath},maxsize=1gb";
profilingConfig = $"-XX:StartFlightRecording=filename={profileOutputPath},maxsize=1gb -XX:+UnlockDiagnosticVMOptions -XX:+DebugNonSafepoints";

// If Java 8 is the version of Java being used add '-XX:+UnlockCommercialFeatures' as that is required to run Java Flight Recording in Java 8.
// Don't add '-XX:+UnlockCommercialFeatures' if it is any other version as this causes the JVM to crash on an unrecognized VM options.
Expand Down