Skip to content

Removable Sanitizers #8120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scbedd merged 26 commits into from
Apr 22, 2024
Merged

Removable Sanitizers #8120

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
15e6946
begin the refactor. need to update wherever we touch sanitizers to en…
scbedd Apr 12, 2024
1f34c08
just save away the progress so that this can be pulled over to anothe…
scbedd Apr 17, 2024
13d6486
making a sanitizer store its id so that we have a consistent value to…
scbedd Apr 17, 2024
b861e01
getting closer. Need to rationalize registration + removal
scbedd Apr 17, 2024
e2304aa
first passing build. now time to discover all the test failures. gon …
scbedd Apr 18, 2024
45332b9
gotta initialize the Sanitizers concurrentDictionary!
scbedd Apr 18, 2024
c9bde0c
all but 3 tests passing
scbedd Apr 18, 2024
2ece462
simplify _register a bit
scbedd Apr 18, 2024
9a16d3e
rid ourselves of csharp9 call
scbedd Apr 18, 2024
8e2a873
committing progress w/ incomplete new routes
scbedd Apr 18, 2024
b92dec5
reference a specific branch for harsha to explore on
scbedd Apr 18, 2024
a1ae82e
remove some usings
scbedd Apr 18, 2024
053ce5e
we are getting a ton closer
scbedd Apr 18, 2024
95cb685
attempt interlocked increment with the automatic id
scbedd Apr 19, 2024
ef69312
further feedback to avoid ever having a problem
scbedd Apr 19, 2024
c77d722
skin out the tests
scbedd Apr 19, 2024
a3d7d17
repair admin test
scbedd Apr 19, 2024
755d0b2
forgot to set content length woops
scbedd Apr 19, 2024
a40939a
now we're properly writing the responses from Admin
scbedd Apr 19, 2024
2dde663
actually fix the first test
scbedd Apr 19, 2024
518066b
we can actually remove sanitizers now
scbedd Apr 19, 2024
d52c08e
we can remove sanitizers by route now. time to test
scbedd Apr 20, 2024
4cb7012
now it is connected top to bottom. tests only remain
scbedd Apr 20, 2024
f6fb3ce
adding the tests and catching a bug in recording-specific sanitizer r…
scbedd Apr 22, 2024
75fcad2
small correction on returned result
scbedd Apr 22, 2024
02cd858
Update tools/test-proxy/Azure.Sdk.Tools.TestProxy/Properties/launchSe…
scbedd Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update tools/test-proxy/Azure.Sdk.Tools.TestProxy/Properties/launchSe… 
…ttings.json
  • Loading branch information
@scbedd
scbedd authored Apr 22, 2024
commit 02cd858730fc6a7b47b66e18de3ced100aa1221e
1 change: 0 additions & 1 deletion tools/test-proxy/Azure.Sdk.Tools.TestProxy/Properties/launchSettings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
"profiles": {
"Azure.Sdk.Tools.TestProxy": {
"commandName": "Project",
"commandLineArgs": "--storage-location=C:/repo/sdk-for-js",
"environmentVariables": {
"ASPNETCORE_ENVIRONMENT": "Development",
"Logging__LogLevel__Microsoft": "Information"
Expand Down