-
Notifications
You must be signed in to change notification settings - Fork 226
Prevent release with critical failures #8198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
WhitShake
merged 13 commits into
Azure:main
from
WhitShake:prevent-release-with-critical-failures
May 7, 2024
Merged
Prevent release with critical failures #8198
WhitShake
merged 13 commits into
Azure:main
from
WhitShake:prevent-release-with-critical-failures
May 7, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…verride to approve
src/dotnet/APIView/APIViewWeb/Pages/Assemblies/Review.cshtml.cs
Outdated
Show resolved
Hide resolved
src/dotnet/APIView/APIViewWeb/Pages/Assemblies/Review.cshtml.cs
Outdated
Show resolved
Hide resolved
chidozieononiwu
requested changes
May 3, 2024
Member
chidozieononiwu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets deploy to staging to test it out. Also seems like the razor pages got screwed up a bit. Happens at time will need to take a closer look.
chidozieononiwu
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User will be notified via popup if Fatal diagnostics or open conversations are present when attempting approval. Issue checkboxes must be checked to override and continue approval.