Use repositories file by default for GH scripts #8527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default UX shouldn't change: to override any default values for disambiguating parameters, you had to pass values. If we change the default parameter set (or, for a couple scripts, leave it) to use the file we can remove the duplicate repo and language information from the `-Repositories` and `-Languages` parameters because to override those - even if they were the default parameter - you had to specify a different value. The end result should be no change. Also cleans up warnings in the README and a couple other scripts using their respective linters I have enabled in VSCode.
hallipr
approved these changes
Jul 1, 2024
jsquire
requested changes
Jul 1, 2024
Member
jsquire
left a comment
jsquire
left a comment
There was a problem hiding this comment.
Good with the script changes, but I'd like to retain the README formatting as it was.
jsquire
reviewed
Jul 1, 2024
jsquire
approved these changes
Jul 1, 2024
Member
Author
|
/check-enforcer override |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default UX shouldn't change: to override any default values for disambiguating parameters, you had to pass values. If we change the default parameter set (or, for a couple scripts, leave it) to use the file we can remove the duplicate repo and language information from the
-Repositoriesand-Languagesparameters because to override those - even if they were the default parameter - you had to specify a different value. The end result should be no change.Also cleans up warnings in the README and a couple other scripts using their respective linters I have enabled in VSCode.