Refactor tsp-client to use yargs #8607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjprescott
force-pushed
the
tsp-client/compare
branch
from
ccd6b7b to
aa43f20
Compare
Member
catalinaperalta
left a comment
catalinaperalta
left a comment
There was a problem hiding this comment.
This looks good :) I think we should wait to merge this until I have the test script checked in to make sure none of the main usage scenarios are broken since this is a pretty big change. Also, since we're changing the generate lock file functionality from a flag to a command we should bump tsp-client version to 0.10.0
…tsp-client/compare
* refactor commands * add test files * add sync tests * rename test file * clean up test * fix update command tsp-location.yaml logic * add update tests * init fix and test --------- Co-authored-by: Catalina Peralta <[email protected]>
…tsp-client/compare
…tsp-client/compare
catalinaperalta
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts tsp-client to use
yargsinstead ofnode:utilfor parsing, as it is a full-fledged CLI tool and benefits from the yargs framework.