Skip to content

Update AreAPICodeFilesTheSame #8641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
praveenkuttappan merged 3 commits into from
Jul 16, 2024
Merged

Update AreAPICodeFilesTheSame #8641

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
df0cfa6
Handle AreAPICodeFilesTheSame for cases where the Parser Version is d…
chidozieononiwu Jul 16, 2024
2325c9d
Deserialize code file using correct foramt
praveenkuttappan Jul 16, 2024
09b60b2
Sanitize token code file name
praveenkuttappan Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/dotnet/APIView/APIViewWeb/Managers/CodeFileManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,11 @@ public async Task<APICodeFileModel> CreateReviewCodeFileModel(string apiRevision
/// <returns></returns>
public async Task<bool> AreAPICodeFilesTheSame(RenderedCodeFile codeFileA, RenderedCodeFile codeFileB)
{
if (codeFileA.CodeFile.VersionString != codeFileA.CodeFile.VersionString)
{
return false;
}

if (LanguageServiceHelpers.UseTreeStyleParser(codeFileA.CodeFile.Language))
{
var diffTree =CodeFileHelpers.ComputeAPIForestDiff(codeFileA.CodeFile.APIForest, codeFileB.CodeFile.APIForest);
Expand Down