Refactor apiviewgo type definition hoisting #8668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7866. Main goal here is to create a spot (the TODO in
Review.resolveAliases) to handle type aliases (type Event = log.Event) referring to non-SDK modules.TypeAliastype carries data about aliases, hoists the definition to the aliasing package when given atypeDefReviewtype collects modules implicated in the review, resolves cross-module references, computes outputModulenow surfaces its cross-module type aliases forReviewto resolve instead of resolving them itselfAlong the way I appear to have incidentally fixed a bug that omitted type aliases referring to underlying types. For example, ExpiryTypeAbsolute doesn't appear in the latest azblob review. With this PR, it will appear without a hoisted definition; #8667 tracks improving that.