remove the other prototypes

tools/test-proxy/Azure.Sdk.Tools.TestProxy/Common/RecordSession.cs

@@ -82,20 +82,6 @@ public void Record(RecordEntry entry)
             }
         }
 
-        public RecordEntry NonLockingLookup(RecordEntry requestEntry, RecordMatcher matcher, IEnumerable<RecordedTestSanitizer> sanitizers, string sessionId = null)
-        {
-            foreach (RecordedTestSanitizer sanitizer in sanitizers)
-            {
-                sanitizer.Sanitize(requestEntry);
-            }
-            // normalize request body with STJ using relaxed escaping to match behavior when Deserializing from session files
-            RecordEntry.NormalizeJsonBody(requestEntry.Request);
-
-            RecordEntry entry = matcher.FindMatch(requestEntry, Entries);
-
-            return entry;
-        }
-
         public RecordEntry Lookup(RecordEntry requestEntry, RecordMatcher matcher, IEnumerable<RecordedTestSanitizer> sanitizers, bool remove = true, string sessionId = null)
         {
             foreach (RecordedTestSanitizer sanitizer in sanitizers)
@@ -105,30 +91,19 @@ public RecordEntry Lookup(RecordEntry requestEntry, RecordMatcher matcher, IEnum
             // normalize request body with STJ using relaxed escaping to match behavior when Deserializing from session files
             RecordEntry.NormalizeJsonBody(requestEntry.Request);
 
-            lock (Entries)
+            RecordEntry entry = matcher.FindMatch(requestEntry, Entries);
+            if (remove)
             {
-                RecordEntry entry = matcher.FindMatch(requestEntry, Entries);
-                if (remove)
-                {
-                    Entries.Remove(entry);
-                    DebugLogger.LogInformation($"We successfully matched and popped request URI {entry.RequestUri} for recordingId {sessionId}");
-                }
-
-                return entry;
+                Entries.Remove(entry);
+                DebugLogger.LogInformation($"We successfully matched and popped request URI {entry.RequestUri} for recordingId {sessionId}");
             }
-        }
 
-        public void NonLockingRemove(RecordEntry entry)
-        {
-            Entries.Remove(entry);
+            return entry;
         }
 
         public void Remove(RecordEntry entry)
         {
-            lock (Entries)
-            {
-                Entries.Remove(entry);
-            }
+            Entries.Remove(entry);
         }
 
         public void Sanitize(RecordedTestSanitizer sanitizer)

tools/test-proxy/Azure.Sdk.Tools.TestProxy/RecordingHandler.cs

@@ -475,7 +475,7 @@ public async Task HandlePlaybackRequest(string recordingId, HttpRequest incoming
             lock (session.Session.Entries)
             {
                 // Session may be removed later, but only after response has been fully written
-                var match = session.Session.NonLockingLookup(entry, session.CustomMatcher ?? Matcher, sanitizers, sessionId: recordingId);
+                var match = session.Session.Lookup(entry, session.CustomMatcher ?? Matcher, sanitizers, remove: false, sessionId: recordingId);
 
                 foreach (ResponseTransform transform in Transforms.Concat(session.AdditionalTransforms))
                 {
@@ -517,7 +517,7 @@ public async Task HandlePlaybackRequest(string recordingId, HttpRequest incoming
 
                 if (remove)
                 {
-                    session.Session.NonLockingRemove(match);
+                    session.Session.Remove(match);
                 }
             }
         }

tools/test-proxy/Azure.Sdk.Tools.TestProxy/Startup.cs

@@ -230,13 +230,6 @@ public void ConfigureServices(IServiceCollection services)
 
         public void Configure(IApplicationBuilder app, IWebHostEnvironment env, ILoggerFactory loggerFactory)
         {
-            int maxWorkerThreads, maxCompletionPortThreads;
-            ThreadPool.GetMaxThreads(out maxWorkerThreads, out maxCompletionPortThreads);
-            System.Console.WriteLine($"Default max worker threads: {maxWorkerThreads}");
-            System.Console.WriteLine($"Default max completion port threads: {maxCompletionPortThreads}");
-
-
-
             if (env.IsDevelopment())
             {
                 app.UseDeveloperExceptionPage();