Skip to content

Fix Documentation Issues during Diff #8733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chidozieononiwu merged 2 commits into from
Jul 31, 2024
Merged

Fix Documentation Issues during Diff #8733

chidozieononiwu merged 2 commits into from
Jul 31, 2024

Conversation

@chidozieononiwu
Copy link
Member

@chidozieononiwu chidozieononiwu commented Jul 31, 2024 •
edited
Loading

  • Refactor related models in to different files.
  • Update Diffing logic so that it does not show nodes or tree with diff in only docs when documentation is not enabled.
  • Add a message on the page when there is no diff between the revisions being compared.

@chidozieononiwu chidozieononiwu force-pushed the 073024.01/DocsAndDiff branch from 9661bd7 to 9818ce7 Compare July 31, 2024 22:04
benbp
benbp reviewed Jul 31, 2024
View reviewed changes
benbp
benbp approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@benbp benbp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions but LGTM

@chidozieononiwu chidozieononiwu force-pushed the 073024.01/DocsAndDiff branch from 9818ce7 to 5df646a Compare July 31, 2024 23:05
@chidozieononiwu chidozieononiwu merged commit c9853b6 into Azure:main Jul 31, 2024
@maririos maririos mentioned this pull request Aug 5, 2024
Closed
2 tasks
@maorleger maorleger mentioned this pull request Feb 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benbp benbp benbp approved these changes

@maririos maririos Awaiting requested review from maririos maririos is a code owner

@praveenkuttappan praveenkuttappan Awaiting requested review from praveenkuttappan praveenkuttappan is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chidozieononiwu @benbp