Final Refactor

tools/pylint-extensions/azure-pylint-guidelines-checker/pylint_guidelines_checker.py

@@ -2773,7 +2773,8 @@ def visit_call(self, node):
 
         # Obtain a list of all functions and function names
         functions = []
-        if klass is not None:
+        try:
+            klass.body
             for item in klass.body:
                 if hasattr(item, 'name'):
                     functions.append(item)
@@ -2801,6 +2802,9 @@ def visit_call(self, node):
                                     node=node,
                                     confidence=None,
                                 )
+        except:
+            pass
+
 
     def is_function_async(self, node):
         """Check if a function is async"""
@@ -2816,8 +2820,6 @@ def is_function_async(self, node):
                 return False
 
 
-
-
 # [Pylint] Custom Linter check for Exception Logging #3227
 # [Pylint] Address Commented out Pylint Custom Plugin Checkers #3228
 # [Pylint] Add a check for connection_verify hardcoded settings #35355

tools/pylint-extensions/azure-pylint-guidelines-checker/tests/test_files/invalid_use_of_overload_violation.py → tools/pylint-extensions/azure-pylint-guidelines-checker/tests/test_files/invalid_use_of_overload_violation_1.py

@@ -1,4 +1,4 @@
-# Test file for InvalidUseOfOverload checker
+# Test file for InvalidUseOfOverload checker - testing what mypy doesn't pick up
 
 from typing import Awaitable, overload, Union
 
@@ -14,4 +14,4 @@ def double(a: int):
 async def double(a: Union[str, int]) -> int:
     if isinstance(a, str):
         return len(a)*2
-    return a * 2
+    return a * 2

tools/pylint-extensions/azure-pylint-guidelines-checker/tests/test_files/invalid_use_of_overload_violation_2.py

@@ -0,0 +1,16 @@
+# Test file for InvalidUseOfOverload checker - testing what mypy doesn't pick up
+
+from typing import Awaitable, overload, Union
+
+@overload
+def double(a: str):
+    ...
+
+@overload
+def double(a: int):
+    ...
+
+async def double(a: Union[str, int]) -> int:
+    if isinstance(a, str):
+        return len(a)*2
+    return a * 2

tools/pylint-extensions/azure-pylint-guidelines-checker/tests/test_pylint_custom_plugins.py

@@ -4851,26 +4851,25 @@ def test_valid_use_overload(self):
 
 
     def test_invalid_use_overload(self):
-        file = open(
-            os.path.join(
-                TEST_FOLDER, "test_files", "invalid_use_of_overload_violation.py"
-            )
-        )
-        node = astroid.parse(file.read())
-        file.close()
-        with self.assertAddsMessages(
-            pylint.testutils.MessageTest(
-                msg_id="invalid-use-of-overload",
-                line=0,
-                node=node,
-                col_offset=0,
-            )
-        ):
-            self.checker.visit_call(node)
-
-
-
+        violation_viles = ["_1", "_2"]
+        for violation in violation_viles:
 
+            file = open(
+                os.path.join(
+                    TEST_FOLDER, "test_files", "invalid_use_of_overload_violation"+violation+".py"
+                )
+            )
+            node = astroid.parse(file.read())
+            file.close()
+            with self.assertAddsMessages(
+                pylint.testutils.MessageTest(
+                    msg_id="invalid-use-of-overload",
+                    line=0,
+                    node=node,
+                    col_offset=0,
+                ),
+            ):
+                self.checker.visit_call(node)
 
 
 # [Pylint] Custom Linter check for Exception Logging #3227