-
Notifications
You must be signed in to change notification settings - Fork 227
Remove default sub config sub-config-azure-cloud-test-resources #9229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We no longer want to default the configuration and instead default from the service connection which had the info we need.
| parameters: | ||
| ServiceDirectory: '' | ||
| SubscriptionConfiguration: $(sub-config-azure-cloud-test-resources) | ||
| SubscriptionConfiguration: $(SubscriptionConfiguration) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've defaulted this because this is what deploy-test-resources outputs. It will fix the usages like we have in perf to ensure we have consistent configuration shared between deploy and remove. Should fix issue like https://dev.azure.com/azure-sdk/internal/_build/results?buildId=4252994&view=logs&j=42ded549-05ee-5cdb-7ba7-7a948a0cc056&t=b938c548-640d-5101-7a83-c666c2d131df
|
@benbp the last reference to the default sub config in tools is https://github.com/Azure/azure-sdk-tools/blob/main/eng/pipelines/templates/jobs/stress-cluster-provision.yml#L22. Can you take the item to update it to federated auth and TME? |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#9229 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: Wes Haggard <[email protected]>
We no longer want to default the configuration and instead default from the service connection which had the info we need.