Skip to content

Conversation

@weshaggard
Copy link
Member

We no longer want to default the configuration and instead default from the service connection which had the info we need.

We no longer want to default the configuration and instead
default from the service connection which had the info we need.
@weshaggard weshaggard requested a review from benbp October 22, 2024 00:14
@weshaggard weshaggard requested a review from a team as a code owner October 22, 2024 00:14
parameters:
ServiceDirectory: ''
SubscriptionConfiguration: $(sub-config-azure-cloud-test-resources)
SubscriptionConfiguration: $(SubscriptionConfiguration)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've defaulted this because this is what deploy-test-resources outputs. It will fix the usages like we have in perf to ensure we have consistent configuration shared between deploy and remove. Should fix issue like https://dev.azure.com/azure-sdk/internal/_build/results?buildId=4252994&view=logs&j=42ded549-05ee-5cdb-7ba7-7a948a0cc056&t=b938c548-640d-5101-7a83-c666c2d131df

@weshaggard
Copy link
Member Author

@benbp the last reference to the default sub config in tools is https://github.com/Azure/azure-sdk-tools/blob/main/eng/pipelines/templates/jobs/stress-cluster-provision.yml#L22. Can you take the item to update it to federated auth and TME?

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@weshaggard
Copy link
Member Author

azure-sdk added a commit to Azure/azure-sdk-for-js that referenced this pull request Oct 22, 2024
@weshaggard weshaggard merged commit 240c5e2 into Azure:main Oct 22, 2024
@weshaggard weshaggard deleted the RemoveDefaultSubConfig branch October 22, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants