add type alias scope extend case

tools/js-sdk-release-tools/packages/typescript-codegen-breaking-change-detector/misc/test-cases/patch-detection/baseline-package/patch.api.md

@@ -16,6 +16,9 @@ export interface Routes {
 export type typesChange = "basic" | "remove";
 export type typesRemove = "basic" | "remove";
 
+export type typesExpand = string | number;
+export type typesNarrow = string | number | boolean;
+
 export interface A {a: string;}
 export interface B {b: string;}
 export interface C {c: string;}

tools/js-sdk-release-tools/packages/typescript-codegen-breaking-change-detector/misc/test-cases/patch-detection/current-package/patch.api.md

@@ -20,6 +20,9 @@ export interface Routes {
 export type typesChange = "basic" | "rEmove";
 export type typesAdd = "basic" | "rEmove";
 
+export type typesExpand = string | number | boolean;
+export type typesNarrow = string | number;
+
 export interface A {a: string;}
 export interface B {b: string;}
 export interface C {c: string;}

tools/js-sdk-release-tools/packages/typescript-codegen-breaking-change-detector/package.json

@@ -1,6 +1,6 @@
 {
   "name": "typescript-codegen-breaking-change-detector",
-  "version": "0.5.4",
+  "version": "0.5.5",
   "description": "Detect breaking changes to your TypeScript client generated by open api, typespec and more...",
   "main": "dist/src/index.js",
   "types": "./dist/src/index.d.ts",

tools/js-sdk-release-tools/packages/typescript-codegen-breaking-change-detector/src/azure/diff/declaration-diff.ts

@@ -376,7 +376,7 @@ export function findFunctionBreakingChanges(source: FunctionDeclaration, target:
 }
 
 export function findTypeAliasBreakingChanges(source: TypeAliasDeclaration, target: TypeAliasDeclaration): DiffPair[] {
-  if (source.getType().isAssignableTo(target.getType())) return [];
+  if (source.getType().isAssignableTo(target.getType()) && target.getType().isAssignableTo(source.getType())) return [];
 
   let sourceNameNode: NameNode = { name: source.getName(), node: source };
   let targetNameNode: NameNode = { name: target.getName(), node: target };

tools/js-sdk-release-tools/packages/typescript-codegen-breaking-change-detector/src/azure/patch/patch-detection.ts

@@ -74,7 +74,7 @@ export function patchRoutes(astContext: AstContext): DiffPair[] {
   return [...breakingChangePairs, ...newFeaturePairs];
 }
 
-export function patchUnionType(name: string, astContext: AstContext, assignDirection: AssignDirection): DiffPair[] {
+export function patchTypeAlias(name: string, astContext: AstContext, assignDirection: AssignDirection): DiffPair[] {
   const baseline = astContext.baseline.getTypeAlias(name);
   const current = astContext.current.getTypeAlias(name);
 

tools/js-sdk-release-tools/packages/typescript-codegen-breaking-change-detector/src/tests/patch-detection.test.ts

@@ -3,7 +3,7 @@ import { describe, expect, test } from 'vitest';
 
 import { join } from 'node:path';
 import { createAstContext } from '../azure/detect-breaking-changes';
-import { patchFunction, patchRoutes, patchUnionType } from '../azure/patch/patch-detection';
+import { patchFunction, patchRoutes, patchTypeAlias } from '../azure/patch/patch-detection';
 import { createTempFolder, getFormattedDate } from './utils';
 import { DiffLocation, DiffReasons, AssignDirection } from '../azure/common/types';
 
@@ -142,26 +142,40 @@ describe("patch current tool's breaking changes", async () => {
     try {
       const tempFolder = await createTempFolder(`.tmp/temp-${date}`);
       const astContext = await createAstContext(baselineApiViewPath, currentApiViewPath, tempFolder);
-      let breakingPairs = patchUnionType('typesChange', astContext, AssignDirection.CurrentToBaseline);
+      let breakingPairs = patchTypeAlias('typesChange', astContext, AssignDirection.CurrentToBaseline);
       expect(breakingPairs.length).toBe(1);
       expect(breakingPairs[0].assignDirection).toBe(AssignDirection.CurrentToBaseline);
       expect(breakingPairs[0].location).toBe(DiffLocation.TypeAlias);
       expect(breakingPairs[0].reasons).toBe(DiffReasons.TypeChanged);
       expect(breakingPairs[0].target?.name).toBe('typesChange');
 
-      breakingPairs = patchUnionType('typesRemove', astContext, AssignDirection.CurrentToBaseline);
+      breakingPairs = patchTypeAlias('typesRemove', astContext, AssignDirection.CurrentToBaseline);
       expect(breakingPairs.length).toBe(1);
       expect(breakingPairs[0].assignDirection).toBe(AssignDirection.CurrentToBaseline);
       expect(breakingPairs[0].location).toBe(DiffLocation.TypeAlias);
       expect(breakingPairs[0].reasons).toBe(DiffReasons.Removed);
       expect(breakingPairs[0].target?.name).toBe('typesRemove');
 
-      breakingPairs = patchUnionType('typesAdd', astContext, AssignDirection.CurrentToBaseline);
+      breakingPairs = patchTypeAlias('typesAdd', astContext, AssignDirection.CurrentToBaseline);
       expect(breakingPairs.length).toBe(1);
       expect(breakingPairs[0].assignDirection).toBe(AssignDirection.CurrentToBaseline);
       expect(breakingPairs[0].location).toBe(DiffLocation.TypeAlias);
       expect(breakingPairs[0].reasons).toBe(DiffReasons.Added);
       expect(breakingPairs[0].source?.name).toBe('typesAdd');
+
+      breakingPairs = patchTypeAlias('typesExpand', astContext, AssignDirection.CurrentToBaseline);
+      expect(breakingPairs.length).toBe(1);
+      expect(breakingPairs[0].assignDirection).toBe(AssignDirection.CurrentToBaseline);
+      expect(breakingPairs[0].location).toBe(DiffLocation.TypeAlias);
+      expect(breakingPairs[0].reasons).toBe(DiffReasons.TypeChanged);
+      expect(breakingPairs[0].source?.name).toBe('typesExpand');
+
+      breakingPairs = patchTypeAlias('typesNarrow', astContext, AssignDirection.CurrentToBaseline);
+      expect(breakingPairs.length).toBe(1);
+      expect(breakingPairs[0].assignDirection).toBe(AssignDirection.CurrentToBaseline);
+      expect(breakingPairs[0].location).toBe(DiffLocation.TypeAlias);
+      expect(breakingPairs[0].reasons).toBe(DiffReasons.TypeChanged);
+      expect(breakingPairs[0].source?.name).toBe('typesNarrow');
     } finally {
       if (tempFolder) remove(tempFolder);
     }