Finish docs cleanup #9331
Merged
Finish docs cleanup #9331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
The following pipelines have been queued for testing: |
weshaggard
approved these changes
Nov 5, 2024
This was referenced Nov 7, 2024
danieljurek
approved these changes
Nov 7, 2024
Member
danieljurek
left a comment
danieljurek
left a comment
There was a problem hiding this comment.
JS template release succeeded https://dev.azure.com/azure-sdk/internal/_build/results?buildId=4302407&view=results
azure-sdk
added a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
Nov 7, 2024
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#9331 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: James Suplizio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docker-pull-image.yml template was only used by update-docsms-metadata.yml and even then, only Java, JS and Python. All of the aforementioned languages now use the "2docfx" tools do docs generation verification and no longer require the docker images.
The scripts that took the docker image id as a parameter have had that parameter removed and no longer pass that option to any functions/function pointers.
@danieljurek removed the docker images, themselves.