Skip to content

Properly handle when git encounters an unrecoverable error #9423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scbedd merged 5 commits into from
Nov 26, 2024
Merged

Properly handle when git encounters an unrecoverable error #9423

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5a03131
properly handle it when git is in an unrecoverable state. hopefully n…
scbedd Nov 22, 2024
d5b2a04
move a test from the solution integration to the CLI integration tests
scbedd Nov 23, 2024
dd9fef1
talking out the problem with Ben really highlighted a much simpler so…
scbedd Nov 26, 2024
f186325
properly early exit or return a git failure to the response via middl…
scbedd Nov 26, 2024
ee3f459
fix the test to report the correct error code for the git exception i…
scbedd Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions tools/test-proxy/Azure.Sdk.Tools.TestProxy/Store/GitProcessHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,16 +195,14 @@ public virtual CommandResult Run(string arguments, string workingDirectory)
}
}
}
// exceptions caught here will be to do with inability to start the git process
// otherwise all "error" states should be handled by the output to stdErr and non-zero exitcode.
catch (Exception e)
// exceptions caught here will be to do with inability to recover from a failed git process
// rather than endlessly retrying and concealing the git error from the user, immediately report and exit the process with an error code
catch (GitProcessException e)
{
DebugLogger.LogDebug(e.Message);

result.ExitCode = -1;
result.CommandException = e;
DebugLogger.LogError("Git ran into an unrecoverable error and had to exit. The error output from git is: ");
DebugLogger.LogError(e.Result.StdErr);

throw new GitProcessException(result);
Environment.Exit(1);
}
});

Expand Down
Loading