Skip to content

[tsp-client] Support alternate entrypoint files #9494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
catalinaperalta merged 8 commits into from
Jan 7, 2025
Merged

[tsp-client] Support alternate entrypoint files #9494

catalinaperalta merged 8 commits into from
Jan 7, 2025

Conversation

@catalinaperalta
Copy link
Member

@catalinaperalta catalinaperalta commented Dec 7, 2024 •
edited
Loading

This PR includes:

  • Support alternate entrypoint files through tsp-location.yaml
  • Make sure we give preference to client.tsp over main.tsp for entrypoint file search

Fixes #7133

@catalinaperalta catalinaperalta requested review from joheredi and tjprescott and removed request for joheredi and tjprescott December 10, 2024 01:27
@catalinaperalta catalinaperalta marked this pull request as ready for review December 10, 2024 02:18
tjprescott
tjprescott approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@tjprescott tjprescott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@catalinaperalta
Copy link
Member Author

catalinaperalta commented Jan 7, 2025

/check-enforcer override

@catalinaperalta catalinaperalta merged commit 9b9981e into main Jan 7, 2025
6 checks passed
@catalinaperalta catalinaperalta deleted the tsp-client/entrypoint branch January 7, 2025 18:12
@maorleger maorleger mentioned this pull request Feb 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tjprescott tjprescott tjprescott approved these changes

@joheredi joheredi Awaiting requested review from joheredi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[tsp-client] Add an option to specify an alternate main entry file

4 participants

@catalinaperalta @tjprescott @cperaltah