Skip to content

Migrate JS Package #9511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wanlwanl merged 8 commits into from
Dec 26, 2024
Merged

Migrate JS Package #9511

wanlwanl merged 8 commits into from
Dec 26, 2024

Conversation

@wanlwanl
Copy link
Contributor

@wanlwanl wanlwanl commented Dec 11, 2024

Fix: #9510

@wanlwanl wanlwanl marked this pull request as ready for review December 13, 2024 06:12
@wanlwanl
Copy link
Contributor Author

wanlwanl commented Dec 13, 2024

Tested locally.
found 2 issues in migration tools.
Azure/azure-sdk-for-js#32202
Azure/azure-sdk-for-js#32200

@kazrael2119 Please help to test. in windows platform, you need to modify it as a workaround: https://github.com/Azure/azure-sdk-for-js/pull/32201/files#diff-b5c6091a6b6c3d41963de6bcb4443000186b55d3c8f76469ed31037cb29134fd

qiaozha
qiaozha reviewed Dec 13, 2024
View reviewed changes
@qiaozha
Copy link
Member

qiaozha commented Dec 13, 2024

@mpodwysocki I wonder if we should wait for the migration command for samples update to be ready?

@wanlwanl
Copy link
Contributor Author

wanlwanl commented Dec 13, 2024

@qiaozha please note that there're 2 issues may need to fix by #9511 (comment). but I added a workaround, they won't impact us for now.

@wanlwanl wanlwanl enabled auto-merge (squash) December 13, 2024 06:29
@wanlwanl
Copy link
Contributor Author

wanlwanl commented Dec 18, 2024

@weshaggard could you help? I got the same issue twices recently

@wanlwanl
Copy link
Contributor Author

wanlwanl commented Dec 23, 2024

@chidozieononiwu, @mikeharder: could you please help me?

@qiaozha
Copy link
Member

qiaozha commented Dec 26, 2024

/check-enforcer override

@wanlwanl wanlwanl merged commit 4b6011d into main Dec 26, 2024
4 checks passed
@wanlwanl wanlwanl deleted the wanl/migrate-package branch December 26, 2024 02:57
@weshaggard
Copy link
Member

weshaggard commented Jan 2, 2025

I've re-enabld the ci pipeline so it should trigger for future PRs

@maorleger maorleger mentioned this pull request Feb 4, 2025
Closed
@MaryGao MaryGao mentioned this pull request Feb 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qiaozha qiaozha qiaozha approved these changes

@MaryGao MaryGao Awaiting requested review from MaryGao MaryGao is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migrate Packages of azure-sdk-for-js

5 participants

@wanlwanl @qiaozha @weshaggard @albertxavier100