Skip to content

Updates to PullRequest matrix generation #9601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
scbedd merged 2 commits into from
Jan 17, 2025
Merged

Updates to PullRequest matrix generation #9601

scbedd merged 2 commits into from
Jan 17, 2025

Conversation

@scbedd
Copy link
Member

@scbedd scbedd commented Jan 7, 2025 •
edited
Loading

  • Makes the indirect packages sparse (maybe I should make this a boolean)
  • Allows customization of the batch size for the PR matrix
  • Allows additional filters to the matrix generation for just the indirect included packages.

See specific usage here for why the additional filter is useful. We use the same matrix, but filter it down using the IndirectMatrixFilters. How it looks

@scbedd scbedd requested a review from a team as a code owner January 7, 2025 20:46
@scbedd scbedd self-assigned this Jan 7, 2025
@scbedd scbedd changed the title Updates to PR matrix generation Updates to PullReqest matrix generation Jan 7, 2025
@scbedd scbedd changed the title Updates to PullReqest matrix generation Updates to PullRequest matrix generation Jan 7, 2025
@azure-sdk
Copy link
Collaborator

azure-sdk commented Jan 7, 2025

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

weshaggard
weshaggard reviewed Jan 10, 2025
View reviewed changes
benbp
benbp reviewed Jan 13, 2025
View reviewed changes
benbp
benbp reviewed Jan 13, 2025
View reviewed changes
@azure-sdk
Copy link
Collaborator

azure-sdk commented Jan 15, 2025

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@scbedd scbedd force-pushed the net-pullrequest-pipeline-updates branch from 8f482ab to 9bf184e Compare January 15, 2025 22:19
@azure-sdk
Copy link
Collaborator

azure-sdk commented Jan 15, 2025

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

This was referenced Jan 16, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@scbedd @weshaggard
updates to dynamic matrix generation. moves indirectly included packa…
a238843 
…ges to sparse usage. adds additional parameters to GeneratePRMatrix that enable further filtering of the matrix generated for the indirect packages

adjustments from feedback. currently running in an sdk-for-net branch

Update eng/common/scripts/job-matrix/Create-PrJobMatrix.ps1

Co-authored-by: Wes Haggard <[email protected]>
@scbedd scbedd force-pushed the net-pullrequest-pipeline-updates branch from 9bf184e to a238843 Compare January 16, 2025 21:17
@azure-sdk
Copy link
Collaborator

azure-sdk commented Jan 16, 2025

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@scbedd
in the case where it's all the same matrix (so no batches), not addin…
71337d7 
…g a suffix for the indirect batch causes duplicate config names, so the indirect batch is ignored entirely
@azure-sdk
Copy link
Collaborator

azure-sdk commented Jan 16, 2025

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@scbedd scbedd merged commit 6303e26 into main Jan 17, 2025
12 checks passed
@scbedd scbedd deleted the net-pullrequest-pipeline-updates branch January 17, 2025 20:34
swathipil pushed a commit to swathipil/azure-sdk-tools that referenced this pull request Feb 4, 2025
@scbedd @weshaggard @swathipil
Updates to PullRequest matrix generation (Azure#9601)
c314601 
* updates to dynamic matrix generation. moves indirectly included packages to sparse usage. adds additional parameters to GeneratePRMatrix that enable further filtering of the matrix generated for the indirect packages

---------

Co-authored-by: Wes Haggard <[email protected]>
@maorleger maorleger mentioned this pull request Feb 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benbp benbp benbp left review comments

@weshaggard weshaggard weshaggard approved these changes

Assignees

@scbedd scbedd

Labels

None yet

Projects

Azure SDK EngSys ❄️🎄🎁🎅✨
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@scbedd @azure-sdk @benbp @weshaggard