Skip to content

Conversation

@heaths
Copy link
Member

@heaths heaths commented Jan 14, 2025

No description provided.

@heaths
Copy link
Member Author

heaths commented Jan 14, 2025

This is ready to merge. It *almost( works for me. Getting an error during compilation, but that's an issue with @azure-tools/typespec-rust:

Emitter "@azure-tools/typespec-rust" crashed! This is a bug.
Please file an issue at https://github.com/Azure/typespec-rust/issues

Error: model property kind header NYI
    at Adapter.getModel (file:///home/heaths/src/azure-sdk-for-rust/sdk/core/azure_core_test/TempTypeSpecFiles/node_modules/@azure-tools/typespec-rust/src/tcgcadapter/adapter.ts:194:17)
    at Adapter.adaptTypes (file:///home/heaths/src/azure-sdk-for-rust/sdk/core/azure_core_test/TempTypeSpecFiles/node_modules/@azure-tools/typespec-rust/src/tcgcadapter/adapter.ts:107:30)
    at Adapter.tcgcToCrate (file:///home/heaths/src/azure-sdk-for-rust/sdk/core/azure_core_test/TempTypeSpecFiles/node_modules/@azure-tools/typespec-rust/src/tcgcadapter/adapter.ts:59:10)
    at Object.$onEmit [as emitFunction] (file:///home/heaths/src/azure-sdk-for-rust/sdk/core/azure_core_test/TempTypeSpecFiles/node_modules/@azure-tools/typespec-rust/src/emitter.ts:22:25)
    at runEmitter (file:///home/heaths/src/azure-sdk-for-rust/sdk/core/azure_core_test/TempTypeSpecFiles/node_modules/@typespec/compiler/src/core/program.ts:575:7)
    at compile (file:///home/heaths/src/azure-sdk-for-rust/sdk/core/azure_core_test/TempTypeSpecFiles/node_modules/@typespec/compiler/src/core/program.ts:258:5)
    at compileOnce (file:///home/heaths/src/azure-sdk-for-rust/sdk/core/azure_core_test/TempTypeSpecFiles/node_modules/@typespec/compiler/src/core/cli/actions/compile/compile.ts:65:21)
    at compileAction (file:///home/heaths/src/azure-sdk-for-rust/sdk/core/azure_core_test/TempTypeSpecFiles/node_modules/@typespec/compiler/src/core/cli/actions/compile/compile.ts:31:5)

That is to say, these changes appear to be correct. The TypeSpec is just using something our emitter doesn't support yet.

/cc @jhendrixMSFT

@heaths heaths merged commit 9598c33 into main Jan 16, 2025
22 checks passed
@heaths heaths deleted the heaths-patch-1 branch January 16, 2025 03:06
swathipil pushed a commit to swathipil/azure-sdk-tools that referenced this pull request Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants