Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
ensure that packages that come back from AdditionalValidationPackages…
… are NOT counted as 'includedForValidation: true' if they also exist in the original 'these packages changed' set
  • Loading branch information
scbedd committed Jan 15, 2025
commit 1301a98331f5cf3a02f11ce2c5d35dd44cfbe8d4
9 changes: 7 additions & 2 deletions eng/common/scripts/Package-Properties.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -187,12 +187,17 @@ function Get-PrPkgProperties([string]$InputDiffJson) {
}
}

$existingPackageNames = $packagesWithChanges | ForEach-Object { $_.Name }
foreach ($addition in $additionalValidationPackages) {
$key = $addition.Replace($RepoRoot, "").TrimStart('\/')

if ($lookup[$key]) {
$lookup[$key].IncludedForValidation = $true
$packagesWithChanges += $lookup[$key]
$pkg = $lookup[$key]

if ($pkg.Name -notin $existingPackageNames) {
$pkg.IncludedForValidation = $true
$packagesWithChanges += $pkg
}
}
}

Expand Down
Loading